Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2737123003:
Fix 'pointer', 'any-pointer', 'hover' and 'any-hover' value on detachable/convertible devices. (Closed)
DescriptionFix 'pointer', 'any-pointer', 'hover' and 'any-hover' value on detachable/convertible devices.
On detachable/convertible devices when the keyboard/trackpad combo
is detached/flipped the trackpad or keyboard may still be listed
in Device Manager therefore GetSystemMetrics(SM_MOUSEPRESENT) will
not return 0 and therefore we're assuming there is a mouse/trackpad
connected. The fix is to rely on ConvertibleSlateMode instead which
has been added part of Windows 8 and 10.
BUG=442418
Review-Url: https://codereview.chromium.org/2737123003
Cr-Commit-Position: refs/heads/master@{#457851}
Committed: https://chromium.googlesource.com/chromium/src/+/7b5e4e437bb223e9fd68f749f7b3325356719180
Patch Set 1 #Patch Set 2 : Fix 'pointer', 'any-pointer', 'hover' and 'any-hover' value on detachable/convertible devices. #
Total comments: 1
Patch Set 3 : Fix 'pointer', 'any-pointer', 'hover' and 'any-hover' value on detachable/convertible devices. #
Messages
Total messages: 28 (17 generated)
The CQ bit was checked by alexis.menard@intel.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Fix 'pointer', 'any-pointer', 'hover' and 'any-hover' value on detachable/convertible devices. On detachable/convertible devices when the keyboard/trackpad combo is detached/flipped the trackpad or keyboard may still be listed in Device Manager therefore GetSystemMetrics(SM_MOUSEPRESENT) will not return 0 and therefore we're assuming there is a mouse/trackpad connected. The fix is to rely on ConvertibleSlateMode instead which has been added part of Windows 8 and 10. BUG=442418 ========== to ========== Fix 'pointer', 'any-pointer', 'hover' and 'any-hover' value on detachable/convertible devices. On detachable/convertible devices when the keyboard/trackpad combo is detached/flipped the trackpad or keyboard may still be listed in Device Manager therefore GetSystemMetrics(SM_MOUSEPRESENT) will not return 0 and therefore we're assuming there is a mouse/trackpad connected. The fix is to rely on ConvertibleSlateMode instead which has been added part of Windows 8 and 10. BUG=442418 ==========
alexis.menard@intel.com changed reviewers: + cpu@chromium.org, mustaq@chromium.org, rbyers@chromium.org, sadrul@chromium.org, scottmg@chromium.org
The CQ bit was checked by alexis.menard@intel.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
I am afraid I don't know Windows enough to review this correctly. I can stamp after one of the Windows folks approve.
ananta: IsWindows10TabletMode is your creation, yes? would you take a look at this related change? https://codereview.chromium.org/2737123003/diff/20001/ui/base/touch/touch_dev... File ui/base/touch/touch_device_win.cc (right): https://codereview.chromium.org/2737123003/diff/20001/ui/base/touch/touch_dev... ui/base/touch/touch_device_win.cc:7: #include "ui/base/touch/touch_device.h" since this is conceptually the .h corresponding to this .cc file, it should precede the other headers with a blank line between it and the rest.
The CQ bit was checked by alexis.menard@intel.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
On 2017/03/09 09:39:17, grt (UTC plus 1) wrote: > ananta: IsWindows10TabletMode is your creation, yes? would you take a look at > this related change? Any feedback? > > https://codereview.chromium.org/2737123003/diff/20001/ui/base/touch/touch_dev... > File ui/base/touch/touch_device_win.cc (right): > > https://codereview.chromium.org/2737123003/diff/20001/ui/base/touch/touch_dev... > ui/base/touch/touch_device_win.cc:7: #include "ui/base/touch/touch_device.h" > since this is conceptually the .h corresponding to this .cc file, it should > precede the other headers with a blank line between it and the rest. I fixed that.
seems reasonable, I too would like to see iyengar take a peek.
ananta@chromium.org changed reviewers: + ananta@chromium.org
lgtm
alexis.menard@intel.com changed reviewers: + iyengar@google.com
On 2017/03/16 18:47:43, ananta wrote: > lgtm iyengar any feedback or I can just go ahead and land it?
lgtm
lgtm
The CQ bit was checked by alexis.menard@intel.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1489773123827810,
"parent_rev": "42c074f058c39ca559d47e168dade668b5ec419e", "commit_rev":
"7b5e4e437bb223e9fd68f749f7b3325356719180"}
Message was sent while issue was closed.
Description was changed from ========== Fix 'pointer', 'any-pointer', 'hover' and 'any-hover' value on detachable/convertible devices. On detachable/convertible devices when the keyboard/trackpad combo is detached/flipped the trackpad or keyboard may still be listed in Device Manager therefore GetSystemMetrics(SM_MOUSEPRESENT) will not return 0 and therefore we're assuming there is a mouse/trackpad connected. The fix is to rely on ConvertibleSlateMode instead which has been added part of Windows 8 and 10. BUG=442418 ========== to ========== Fix 'pointer', 'any-pointer', 'hover' and 'any-hover' value on detachable/convertible devices. On detachable/convertible devices when the keyboard/trackpad combo is detached/flipped the trackpad or keyboard may still be listed in Device Manager therefore GetSystemMetrics(SM_MOUSEPRESENT) will not return 0 and therefore we're assuming there is a mouse/trackpad connected. The fix is to rely on ConvertibleSlateMode instead which has been added part of Windows 8 and 10. BUG=442418 Review-Url: https://codereview.chromium.org/2737123003 Cr-Commit-Position: refs/heads/master@{#457851} Committed: https://chromium.googlesource.com/chromium/src/+/7b5e4e437bb223e9fd68f749f7b3... ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/chromium/src/+/7b5e4e437bb223e9fd68f749f7b3... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
