[Offline pages] Clean up of device conditions related code

[Offline pages] Clean up of device conditions related code

This change moves all DeviceConditions related code to that class and
removes all the static methods for propagating conditions from
OfflinePageUtils and other classes, except for the scheduler bridge.

The code also adds a ShadowDeviceConditions to enable mocking of
static methods for testing.

BUG=699261
Review-Url: https://codereview.chromium.org/2737093002
Cr-Commit-Position: refs/heads/master@{#455498}
Committed: https://chromium.googlesource.com/chromium/src/+/4235a8b857d6685b89ae1e5cc4ffe924a7a8ecf5

[fgorski, 2017-03-07 22:07:11]

The CQ bit was checked by fgorski@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-07 22:08:00]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[fgorski, 2017-03-07 22:09:57]

fgorski@chromium.org changed reviewers:
+ petewil@chromium.org

[fgorski, 2017-03-07 22:09:58]

PTAL

https://codereview.chromium.org/2737093002/diff/1/chrome/android/junit/src/or...
File
chrome/android/junit/src/org/chromium/chrome/browser/offlinepages/BackgroundOfflinerTaskTest.java
(right):

https://codereview.chromium.org/2737093002/diff/1/chrome/android/junit/src/or...
chrome/android/junit/src/org/chromium/chrome/browser/offlinepages/BackgroundOfflinerTaskTest.java:80:
// OfflinePageUtils.setInstanceForTesting(mOfflinePageUtils);
remove

[commit-bot: I haz the power, 2017-03-07 23:45:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-07 23:45:18]

Dry run: Try jobs failed on following builders:
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)

[Pete Williamson, 2017-03-08 02:00:26]

lgtm

[fgorski, 2017-03-08 16:48:17]

The CQ bit was checked by fgorski@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-08 16:48:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[fgorski, 2017-03-08 18:12:41]

The CQ bit was unchecked by fgorski@chromium.org

[fgorski, 2017-03-08 18:12:43]

The CQ bit was checked by fgorski@chromium.org

[fgorski, 2017-03-08 18:12:43]

The patchset sent to the CQ was uploaded after l-g-t-m from petewil@chromium.org
Link to the patchset: https://codereview.chromium.org/2737093002/#ps20001
(title: "Compilation fix and small code update")

[fgorski, 2017-03-08 18:12:48]

The CQ bit was checked by fgorski@chromium.org

[commit-bot: I haz the power, 2017-03-08 18:13:05]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-08 18:38:18]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1488996768367690,
"parent_rev": "c0d16f0bde63a69dc117bb2b6860b3dd57f3b25d", "commit_rev":
"4235a8b857d6685b89ae1e5cc4ffe924a7a8ecf5"}

[commit-bot: I haz the power, 2017-03-08 18:39:01]

Description was changed from

==========
[Offline pages] Clean up of device conditions related code

This change moves all DeviceConditions related code to that class and
removes all the static methods for propagating conditions from
OfflinePageUtils and other classes, except for the scheduler bridge.

The code also adds a ShadowDeviceConditions to enable mocking of
static methods for testing.

BUG=699261
==========

to

==========
[Offline pages] Clean up of device conditions related code

This change moves all DeviceConditions related code to that class and
removes all the static methods for propagating conditions from
OfflinePageUtils and other classes, except for the scheduler bridge.

The code also adds a ShadowDeviceConditions to enable mocking of
static methods for testing.

BUG=699261

Review-Url: https://codereview.chromium.org/2737093002
Cr-Commit-Position: refs/heads/master@{#455498}
Committed:
https://chromium.googlesource.com/chromium/src/+/4235a8b857d6685b89ae1e5cc4ff...
==========

[commit-bot: I haz the power, 2017-03-08 18:39:02]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/4235a8b857d6685b89ae1e5cc4ff...