[tools/profview] Add individual function timeline view

[tools/profview] Add individual function timeline view

Adds a bar below the current timeline view which can show the time
when an individual function was on the stack. Functions in the call
stack are now clickable to show them in this view.

Sections where the function was on the stack, but not at the top, are
displayed at half height.

Review-Url: https://codereview.chromium.org/2737083003
Cr-Commit-Position: refs/heads/master@{#43673}
Committed: https://chromium.googlesource.com/v8/v8/+/65a07b7a109dfda09ba6fbfd100ac653bcc9d982

[Leszek Swirski, 2017-03-08 14:11:51]

leszeks@chromium.org changed reviewers:
+ jarin@chromium.org

[Leszek Swirski, 2017-03-08 14:11:52]

Jaro, I've added a single function's timeline display to profview, could you
take a look please?

Mythri+Ross: fyi.

[Jarin, 2017-03-08 14:25:56]

Ha, this exactly what I wanted to do, you are awesome!

lgtm.

https://codereview.chromium.org/2737083003/diff/1/tools/profview/profile-util...
File tools/profview/profile-utils.js (right):

https://codereview.chromium.org/2737083003/diff/1/tools/profview/profile-util...
tools/profview/profile-utils.js:269: this.tree = { name : "root", codeId: -1,
children : [], ownTicks : 0, ticks : 0 };
<80 character lines, please (here and below).

[Leszek Swirski, 2017-03-08 14:32:40]

https://codereview.chromium.org/2737083003/diff/1/tools/profview/profile-util...
File tools/profview/profile-utils.js (right):

https://codereview.chromium.org/2737083003/diff/1/tools/profview/profile-util...
tools/profview/profile-utils.js:269: this.tree = { name : "root", codeId: -1,
children : [], ownTicks : 0, ticks : 0 };
On 2017/03/08 14:25:56, Jarin wrote:
> <80 character lines, please (here and below).

Done.

[Leszek Swirski, 2017-03-08 14:32:49]

The CQ bit was checked by leszeks@chromium.org

[Leszek Swirski, 2017-03-08 14:32:50]

The patchset sent to the CQ was uploaded after l-g-t-m from jarin@chromium.org
Link to the patchset: https://codereview.chromium.org/2737083003/#ps20001
(title: "Fix line lengths")

[commit-bot: I haz the power, 2017-03-08 14:32:53]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-08 14:34:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-08 14:34:05]

Try jobs failed on following builders:
  v8_android_arm_compile_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_android_arm_compile_rel/...)
  v8_linux64_asan_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel_ng/buil...)
  v8_linux64_gyp_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng/build...)
  v8_linux64_verify_csa_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_verify_csa_rel_n...)
  v8_linux_arm64_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel_ng/build...)
  v8_linux_arm_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm_rel_ng/builds/...)
  v8_linux_mipsel_compile_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mipsel_compile_rel...)
  v8_mac_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel_ng/builds/18634)

[Leszek Swirski, 2017-03-08 14:40:12]

The CQ bit was checked by leszeks@chromium.org

[Leszek Swirski, 2017-03-08 14:40:13]

The patchset sent to the CQ was uploaded after l-g-t-m from jarin@chromium.org
Link to the patchset: https://codereview.chromium.org/2737083003/#ps40001
(title: "Rebase")

[commit-bot: I haz the power, 2017-03-08 14:40:23]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-08 15:03:23]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1488984012940510,
"parent_rev": "fb887b8192fe3bd346317853d18b4efd3ef03c0b", "commit_rev":
"65a07b7a109dfda09ba6fbfd100ac653bcc9d982"}

[commit-bot: I haz the power, 2017-03-08 15:03:28]

Description was changed from

==========
[tools/profview] Add individual function timeline view

Adds a bar below the current timeline view which can show the time
when an individual function was on the stack. Functions in the call
stack are now clickable to show them in this view.

Sections where the function was on the stack, but not at the top, are
displayed at half height.
==========

to

==========
[tools/profview] Add individual function timeline view

Adds a bar below the current timeline view which can show the time
when an individual function was on the stack. Functions in the call
stack are now clickable to show them in this view.

Sections where the function was on the stack, but not at the top, are
displayed at half height.

Review-Url: https://codereview.chromium.org/2737083003
Cr-Commit-Position: refs/heads/master@{#43673}
Committed:
https://chromium.googlesource.com/v8/v8/+/65a07b7a109dfda09ba6fbfd100ac653bcc...
==========

[commit-bot: I haz the power, 2017-03-08 15:03:29]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/v8/v8/+/65a07b7a109dfda09ba6fbfd100ac653bcc...

[Jarin, 2017-03-08 16:35:56]

Some additional thoughts.

https://codereview.chromium.org/2737083003/diff/40001/tools/profview/profile-...
File tools/profview/profile-utils.js (right):

https://codereview.chromium.org/2737083003/diff/40001/tools/profview/profile-...
tools/profview/profile-utils.js:403: (topOfStack !== -1 && stack[topOfStack] ===
this.functionCodeId);
This will not quite work for optimized code because there might be several
optimized code objects for one function (and we do count them together). We
likely want to match on funcId if the code is optimized function.

https://codereview.chromium.org/2737083003/diff/40001/tools/profview/profview.js
File tools/profview/profview.js (right):

https://codereview.chromium.org/2737083003/diff/40001/tools/profview/profview...
tools/profview/profview.js:833: generateTree(file, 0, Infinity,
codeIdProcessor);
One thought: for delayed expansions we already have the list of frames where the
function occurred. If we kept the list around, we could use it to display the
function active regions. That should be much faster then walking all the ticks
(even though in my experience, the walk over the ticks is quite fast). In fact,
it should be fast enough to display  the function on mouse hover.