Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(297)

Issue 2737023002: Update GetClientTag/GetStorageKey comments. (Closed)

Created:
3 years, 9 months ago by skym
Modified:
3 years, 9 months ago
CC:
chromium-reviews, rouslan+autofill_chromium.org, rogerm+autofillwatch_chromium.org, sebsg+autofillwatch_chromium.org, browser-components-watch_chromium.org, mathp+autofillwatch_chromium.org, vabr+watchlistautofill_chromium.org, estade+watch_chromium.org, sync-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update GetClientTag/GetStorageKey comments. I mistakenly did not update autocomplete_sync_bridge.h's comment about GetStorageKey() when I changed its format in https://codereview.chromium.org/25981130a02/ . This CL fixes this inaccuracy, and provides a little more context to the comments of both GetClientTag() and GetStorageKey(). BUG= Review-Url: https://codereview.chromium.org/2737023002 Cr-Commit-Position: refs/heads/master@{#455206} Committed: https://chromium.googlesource.com/chromium/src/+/561441d0db9860bb1b079190f27f5a86be38f221

Patch Set 1 #

Patch Set 2 : Small phrasing change. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -11 lines) Patch
M components/autofill/core/browser/webdata/autocomplete_sync_bridge.h View 1 chunk +0 lines, -7 lines 0 comments Download
M components/autofill/core/browser/webdata/autocomplete_sync_bridge.cc View 2 chunks +6 lines, -0 lines 0 comments Download
M components/sync/model/model_type_sync_bridge.h View 1 2 chunks +5 lines, -4 lines 0 comments Download

Messages

Total messages: 19 (13 generated)
skym
PTAL
3 years, 9 months ago (2017-03-07 19:24:04 UTC) #7
Patrick Noland
lgtm
3 years, 9 months ago (2017-03-07 19:29:51 UTC) #8
skym
Adding mathp@ for components/autofill changes, PTAL.
3 years, 9 months ago (2017-03-07 19:30:39 UTC) #10
Mathieu
lgtm
3 years, 9 months ago (2017-03-07 20:33:22 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2737023002/20001
3 years, 9 months ago (2017-03-07 20:40:12 UTC) #16
commit-bot: I haz the power
3 years, 9 months ago (2017-03-07 20:47:41 UTC) #19
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/561441d0db9860bb1b079190f27f...

Powered by Google App Engine
This is Rietveld 408576698