Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(160)

Issue 2736993004: [build] Add v8gen support for PPC/s390 architecture (Closed)

Created:
3 years, 9 months ago by JaideepBajwa
Modified:
3 years, 9 months ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[build] Add v8gen support for PPC/s390 architecture Add PPC/s390 configs to mb_config and BUILD.gn. Also use a script to get host byte ordering. R=machenbach@chromium.org, dpranke@chromium.org BUG= LOG=N Review-Url: https://codereview.chromium.org/2736993004 Cr-Commit-Position: refs/heads/master@{#43751} Committed: https://chromium.googlesource.com/v8/v8/+/a7d07a3d2997281b42bb3a7d18420debf888099a

Patch Set 1 #

Total comments: 1

Patch Set 2 : reverted bots to use gyp #

Unified diffs Side-by-side diffs Delta from patch set Stats (+98 lines, -3 lines) Patch
M .gn View 1 chunk +4 lines, -2 lines 0 comments Download
M BUILD.gn View 2 chunks +37 lines, -1 line 0 comments Download
M infra/mb/mb_config.pyl View 1 2 chunks +40 lines, -0 lines 0 comments Download
A tools/get_byteorder.py View 1 chunk +17 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
Dirk Pranke
This roughly lgtm but I defer to machenbach@.
3 years, 9 months ago (2017-03-08 02:04:21 UTC) #1
Michael Achenbach
https://codereview.chromium.org/2736993004/diff/1/infra/mb/mb_config.pyl File infra/mb/mb_config.pyl (right): https://codereview.chromium.org/2736993004/diff/1/infra/mb/mb_config.pyl#newcode134 infra/mb/mb_config.pyl:134: 'V8 Linux - ppc - sim': 'gn_release_simulate_ppc', Please reflect ...
3 years, 9 months ago (2017-03-09 10:32:16 UTC) #2
Michael Achenbach
To clarify the above comment, I'd land everything, except switching the bots in mb_config.pyl. That ...
3 years, 9 months ago (2017-03-09 10:33:45 UTC) #3
JaideepBajwa
ptal, I've reverted the bots to use gyp. Will upload another CL for the switch ...
3 years, 9 months ago (2017-03-12 05:44:46 UTC) #4
Michael Achenbach
lgtm
3 years, 9 months ago (2017-03-13 08:30:57 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2736993004/20001
3 years, 9 months ago (2017-03-13 15:04:14 UTC) #12
commit-bot: I haz the power
3 years, 9 months ago (2017-03-13 15:05:57 UTC) #15
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/a7d07a3d2997281b42bb3a7d18420debf88...

Powered by Google App Engine
This is Rietveld 408576698