Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 2736953003: Removing unused PreviewsDataSavings (Closed)

Created:
3 years, 9 months ago by RyanSturm
Modified:
3 years, 9 months ago
Reviewers:
sclittle
CC:
chromium-reviews, blundell+watchlist_chromium.org, sdefresne+watchlist_chromium.org, droger+watchlist_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Removing unused PreviewsDataSavings PreviewsDataSavings is an unused class that is unnecessary. Initially, this was intended to be used by previews to record savings for various previews and hook it into the data_reduction_proxy savings logic. This design doesn't make sense right now for the previews considered, and previews should track their own savings. As previews progresses, the data savings can be moved from d_r_p if necessary into previews, but the dependency from previews to d_r_p is largely backwards. BUG=699264 Review-Url: https://codereview.chromium.org/2736953003 Cr-Commit-Position: refs/heads/master@{#455388} Committed: https://chromium.googlesource.com/chromium/src/+/3f2aebea4889eee1f1d960590605a4544da63f51

Patch Set 1 #

Patch Set 2 : removing drp codepaths only used by previews/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -391 lines) Patch
M components/data_reduction_proxy/core/browser/data_reduction_proxy_compression_stats.h View 1 2 chunks +0 lines, -8 lines 0 comments Download
M components/data_reduction_proxy/core/browser/data_reduction_proxy_compression_stats.cc View 1 1 chunk +0 lines, -14 lines 0 comments Download
M components/data_reduction_proxy/core/browser/data_reduction_proxy_compression_stats_unittest.cc View 1 1 chunk +0 lines, -22 lines 0 comments Download
M components/data_reduction_proxy/core/browser/data_reduction_proxy_settings.h View 1 3 chunks +1 line, -8 lines 0 comments Download
M components/data_reduction_proxy/core/browser/data_reduction_proxy_settings.cc View 1 1 chunk +0 lines, -11 lines 0 comments Download
M components/data_reduction_proxy/core/browser/data_reduction_proxy_settings_unittest.cc View 1 1 chunk +0 lines, -3 lines 0 comments Download
M components/data_reduction_proxy/core/common/BUILD.gn View 1 1 chunk +0 lines, -1 line 0 comments Download
D components/data_reduction_proxy/core/common/data_savings_recorder.h View 1 1 chunk +0 lines, -30 lines 0 comments Download
M components/previews/core/BUILD.gn View 4 chunks +0 lines, -5 lines 0 comments Download
M components/previews/core/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
D components/previews/core/previews_data_savings.h View 1 chunk +0 lines, -51 lines 0 comments Download
D components/previews/core/previews_data_savings.cc View 1 chunk +0 lines, -71 lines 0 comments Download
D components/previews/core/previews_data_savings_unittest.cc View 1 chunk +0 lines, -166 lines 0 comments Download

Messages

Total messages: 14 (10 generated)
RyanSturm
sclittle: PTAL, make sure you don't need the extra d_r_p paths I am removing. If ...
3 years, 9 months ago (2017-03-07 23:37:07 UTC) #6
sclittle
LGTM! Hooray for code deletion!
3 years, 9 months ago (2017-03-07 23:40:39 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2736953003/20001
3 years, 9 months ago (2017-03-08 05:49:55 UTC) #11
commit-bot: I haz the power
3 years, 9 months ago (2017-03-08 05:57:39 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/3f2aebea4889eee1f1d960590605...

Powered by Google App Engine
This is Rietveld 408576698