Start to decouple display::Display from ws::PlatformDisplay.

Start to decouple display::Display from ws::PlatformDisplay.

External window mode will be saner if ws::PlatformDisplay is just a
pixel area and wasn't linked to the concept of display::Display. This is
because there won't be a ws::PlatformDisplay per display::Display in
external window mode.

This CL aims to simplify ws::PlatformDisplay so it is closer to just
understanding it's pixel size. Leave TODOs where further changes are
necessary.

1. Remove non-viewport information from ViewportMetrics. This way
   ws::PlatformDisplay only knows about the pixel size. It has to use
   it's delegate to get the display::Display (which might eventually
   become unnecessary).
2. Pass display::Display along with ViewportMetrics to
   ScreenManagerDelegate. This contains all the information removed from
   ViewportMetrics.
3. Delete PlatformDisplayInitParams. It's just the root ServerWindow +
   ViewportMetrics after changes so that can be passed in directly.
4. Update TestScreenManager to take a Display instead of a
   ViewportMetrics and update tests.
5. Remove a few unnecessary bits of the PlatformDisplay interface.

BUG=693081
Review-Url: https://codereview.chromium.org/2736943003
Cr-Commit-Position: refs/heads/master@{#456565}
Committed: https://chromium.googlesource.com/chromium/src/+/4955b5d118973d7f99d3e5aa10e97b2446758d79

[kylechar, 2017-03-13 15:39:34]

Description was changed from

==========
Cleanup ws::Display and ws::PlatformDisplay.

WIP.

BUG=
==========

to

==========
Start to decouple display::Display from ws::PlatformDisplay.

External window mode will be saner if ws::PlatformDisplay is just a
pixel area and wasn't linked to the concept of display::Display. This is
because there won't be a ws::PlatformDisplay per display::Display in
external window mode.

This CL aims to simplify ws::PlatformDisplay so it is closer to just
understanding it's pixel size.

1. Remove non-viewport information from ViewportMetrics. This way
   ws::PlatformDisplay only knows about the pixel size.
2. Pass display::Display along with ViewportMetrics to
   ScreenManagerDelegate. This contains all the information removed from
   ViewportMetrics.
3. Delete PlatformDisplayInitParams. It's just the root ServerWindow +
   ViewportMetrics now.
4. Update TestScreenManager to take a Display instead of a
   ViewportMetrics.
5. Simplify PlatformDisplayDelegate.
6.

BUG=693081
==========

[kylechar, 2017-03-13 15:48:12]

Patchset #3 (id:40001) has been deleted

[kylechar, 2017-03-13 15:48:16]

Patchset #2 (id:20001) has been deleted

[kylechar, 2017-03-13 15:57:16]

Description was changed from

==========
Start to decouple display::Display from ws::PlatformDisplay.

External window mode will be saner if ws::PlatformDisplay is just a
pixel area and wasn't linked to the concept of display::Display. This is
because there won't be a ws::PlatformDisplay per display::Display in
external window mode.

This CL aims to simplify ws::PlatformDisplay so it is closer to just
understanding it's pixel size.

1. Remove non-viewport information from ViewportMetrics. This way
   ws::PlatformDisplay only knows about the pixel size.
2. Pass display::Display along with ViewportMetrics to
   ScreenManagerDelegate. This contains all the information removed from
   ViewportMetrics.
3. Delete PlatformDisplayInitParams. It's just the root ServerWindow +
   ViewportMetrics now.
4. Update TestScreenManager to take a Display instead of a
   ViewportMetrics.
5. Simplify PlatformDisplayDelegate.
6.

BUG=693081
==========

to

==========
Start to decouple display::Display from ws::PlatformDisplay.

External window mode will be saner if ws::PlatformDisplay is just a
pixel area and wasn't linked to the concept of display::Display. This is
because there won't be a ws::PlatformDisplay per display::Display in
external window mode.

This CL aims to simplify ws::PlatformDisplay so it is closer to just
understanding it's pixel size. Leave TODOs where further changes are
necessary.

1. Remove non-viewport information from ViewportMetrics. This way
   ws::PlatformDisplay only knows about the pixel size. It has to use
   it's delegate to get the display::Display (which might eventually
   become unnecessary).
2. Pass display::Display along with ViewportMetrics to
   ScreenManagerDelegate. This contains all the information removed from
   ViewportMetrics.
3. Delete PlatformDisplayInitParams. It's just the root ServerWindow +
   ViewportMetrics after changes so that can be passed in directly.
4. Update TestScreenManager to take a Display instead of a
   ViewportMetrics and update tests.
5. Remove a few unnecessary bits of the PlatformDisplay interface.

BUG=693081
==========

[kylechar, 2017-03-13 15:59:20]

Description was changed from

==========
Start to decouple display::Display from ws::PlatformDisplay.

External window mode will be saner if ws::PlatformDisplay is just a
pixel area and wasn't linked to the concept of display::Display. This is
because there won't be a ws::PlatformDisplay per display::Display in
external window mode.

This CL aims to simplify ws::PlatformDisplay so it is closer to just
understanding it's pixel size. Leave TODOs where further changes are
necessary.

1. Remove non-viewport information from ViewportMetrics. This way
   ws::PlatformDisplay only knows about the pixel size. It has to use
   it's delegate to get the display::Display (which might eventually
   become unnecessary).
2. Pass display::Display along with ViewportMetrics to
   ScreenManagerDelegate. This contains all the information removed from
   ViewportMetrics.
3. Delete PlatformDisplayInitParams. It's just the root ServerWindow +
   ViewportMetrics after changes so that can be passed in directly.
4. Update TestScreenManager to take a Display instead of a
   ViewportMetrics and update tests.
5. Remove a few unnecessary bits of the PlatformDisplay interface.

BUG=693081
==========

to

==========
Start to decouple display::Display from ws::PlatformDisplay.

External window mode will be saner if ws::PlatformDisplay is just a
pixel area and wasn't linked to the concept of display::Display. This is
because there won't be a ws::PlatformDisplay per display::Display in
external window mode.

This CL aims to simplify ws::PlatformDisplay so it is closer to just
understanding it's pixel size. Leave TODOs where further changes are
necessary.

1. Remove non-viewport information from ViewportMetrics. This way
   ws::PlatformDisplay only knows about the pixel size. It has to use
   it's delegate to get the display::Display (which might eventually
   become unnecessary).
2. Pass display::Display along with ViewportMetrics to
   ScreenManagerDelegate. This contains all the information removed from
   ViewportMetrics.
3. Delete PlatformDisplayInitParams. It's just the root ServerWindow +
   ViewportMetrics after changes so that can be passed in directly.
4. Update TestScreenManager to take a Display instead of a
   ViewportMetrics and update tests.
5. Remove a few unnecessary bits of the PlatformDisplay interface.

BUG=693081
==========

[kylechar, 2017-03-13 15:59:27]

kylechar@chromium.org changed reviewers:
+ sky@chromium.org

[kylechar, 2017-03-13 15:59:27]

+sky for OWNERS
+tonikitoo, fwang and riajiang for TODOs

[sky, 2017-03-13 18:29:07]

https://codereview.chromium.org/2736943003/diff/80001/services/ui/display/vie...
File services/ui/display/viewport_metrics.h (right):

https://codereview.chromium.org/2736943003/diff/80001/services/ui/display/vie...
services/ui/display/viewport_metrics.h:17: gfx::Rect bounds;  // Pixels
Please name this bounds_in_pixels to make it less error prone.

https://codereview.chromium.org/2736943003/diff/80001/services/ui/ws/display.h
File services/ui/ws/display.h (right):

https://codereview.chromium.org/2736943003/diff/80001/services/ui/ws/display....
services/ui/ws/display.h:83: display::Display GetDisplay() override;
Can this return a const Display& ?

https://codereview.chromium.org/2736943003/diff/80001/services/ui/ws/display_...
File services/ui/ws/display_manager.cc (right):

https://codereview.chromium.org/2736943003/diff/80001/services/ui/ws/display_...
services/ui/ws/display_manager.cc:186: VLOG(1) << "OnDisplayAdded: " <<
display.ToString();
We've been using level 3 for informational messages (which this fits in). Also,
can you use DVLOG?

https://codereview.chromium.org/2736943003/diff/80001/services/ui/ws/platform...
File services/ui/ws/platform_display_default.cc (right):

https://codereview.chromium.org/2736943003/diff/80001/services/ui/ws/platform...
services/ui/ws/platform_display_default.cc:150: // TODO(riajiang): This is
broken for HDPI because it mixes PPs and DIPs.
Please file a bug on this to make sure we don't miss it.

[kylechar, 2017-03-13 19:28:02]

https://codereview.chromium.org/2736943003/diff/80001/services/ui/display/vie...
File services/ui/display/viewport_metrics.h (right):

https://codereview.chromium.org/2736943003/diff/80001/services/ui/display/vie...
services/ui/display/viewport_metrics.h:17: gfx::Rect bounds;  // Pixels
On 2017/03/13 18:29:06, sky wrote:
> Please name this bounds_in_pixels to make it less error prone.

Done.

https://codereview.chromium.org/2736943003/diff/80001/services/ui/ws/display.h
File services/ui/ws/display.h (right):

https://codereview.chromium.org/2736943003/diff/80001/services/ui/ws/display....
services/ui/ws/display.h:83: display::Display GetDisplay() override;
On 2017/03/13 18:29:06, sky wrote:
> Can this return a const Display& ?

Yep! I missed that it wasn't.

https://codereview.chromium.org/2736943003/diff/80001/services/ui/ws/display_...
File services/ui/ws/display_manager.cc (right):

https://codereview.chromium.org/2736943003/diff/80001/services/ui/ws/display_...
services/ui/ws/display_manager.cc:186: VLOG(1) << "OnDisplayAdded: " <<
display.ToString();
On 2017/03/13 18:29:06, sky wrote:
> We've been using level 3 for informational messages (which this fits in).
Also,
> can you use DVLOG?

Done.

https://codereview.chromium.org/2736943003/diff/80001/services/ui/ws/platform...
File services/ui/ws/platform_display_default.cc (right):

https://codereview.chromium.org/2736943003/diff/80001/services/ui/ws/platform...
services/ui/ws/platform_display_default.cc:150: // TODO(riajiang): This is
broken for HDPI because it mixes PPs and DIPs.
On 2017/03/13 18:29:07, sky wrote:
> Please file a bug on this to make sure we don't miss it.

Done. I've referenced the bug here.

[kylechar, 2017-03-13 20:34:11]

The CQ bit was checked by kylechar@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-13 20:35:03]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-13 21:59:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-13 21:59:44]

Dry run: This issue passed the CQ dry run.

[sky, 2017-03-13 23:56:13]

LGTM

[kylechar, 2017-03-14 00:10:39]

The CQ bit was checked by kylechar@chromium.org

[commit-bot: I haz the power, 2017-03-14 00:11:21]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-14 01:55:44]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1489450239489620,
"parent_rev": "761ef91ba5d44f137daac6504c88490a207c7765", "commit_rev":
"4955b5d118973d7f99d3e5aa10e97b2446758d79"}

[commit-bot: I haz the power, 2017-03-14 01:56:50]

Description was changed from

==========
Start to decouple display::Display from ws::PlatformDisplay.

External window mode will be saner if ws::PlatformDisplay is just a
pixel area and wasn't linked to the concept of display::Display. This is
because there won't be a ws::PlatformDisplay per display::Display in
external window mode.

This CL aims to simplify ws::PlatformDisplay so it is closer to just
understanding it's pixel size. Leave TODOs where further changes are
necessary.

1. Remove non-viewport information from ViewportMetrics. This way
   ws::PlatformDisplay only knows about the pixel size. It has to use
   it's delegate to get the display::Display (which might eventually
   become unnecessary).
2. Pass display::Display along with ViewportMetrics to
   ScreenManagerDelegate. This contains all the information removed from
   ViewportMetrics.
3. Delete PlatformDisplayInitParams. It's just the root ServerWindow +
   ViewportMetrics after changes so that can be passed in directly.
4. Update TestScreenManager to take a Display instead of a
   ViewportMetrics and update tests.
5. Remove a few unnecessary bits of the PlatformDisplay interface.

BUG=693081
==========

to

==========
Start to decouple display::Display from ws::PlatformDisplay.

External window mode will be saner if ws::PlatformDisplay is just a
pixel area and wasn't linked to the concept of display::Display. This is
because there won't be a ws::PlatformDisplay per display::Display in
external window mode.

This CL aims to simplify ws::PlatformDisplay so it is closer to just
understanding it's pixel size. Leave TODOs where further changes are
necessary.

1. Remove non-viewport information from ViewportMetrics. This way
   ws::PlatformDisplay only knows about the pixel size. It has to use
   it's delegate to get the display::Display (which might eventually
   become unnecessary).
2. Pass display::Display along with ViewportMetrics to
   ScreenManagerDelegate. This contains all the information removed from
   ViewportMetrics.
3. Delete PlatformDisplayInitParams. It's just the root ServerWindow +
   ViewportMetrics after changes so that can be passed in directly.
4. Update TestScreenManager to take a Display instead of a
   ViewportMetrics and update tests.
5. Remove a few unnecessary bits of the PlatformDisplay interface.

BUG=693081

Review-Url: https://codereview.chromium.org/2736943003
Cr-Commit-Position: refs/heads/master@{#456565}
Committed:
https://chromium.googlesource.com/chromium/src/+/4955b5d118973d7f99d3e5aa10e9...
==========

[commit-bot: I haz the power, 2017-03-14 01:56:51]

Committed patchset #4 (id:100001) as
https://chromium.googlesource.com/chromium/src/+/4955b5d118973d7f99d3e5aa10e9...