Add sound volume to device attribute reporting

Add sound volume to device attribute reporting

This CL adds another device attribute to the report which is uploaded to admin console.

More context can be found by reading the design doc go/remote-audio-management

BUG=699589
Review-Url: https://codereview.chromium.org/2736903004
Cr-Commit-Position: refs/heads/master@{#456039}
Committed: https://chromium.googlesource.com/chromium/src/+/f4366520e5828318c92113012e02f1027779a792

[Ivan Šandrk, 2017-03-08 15:44:56]

The CQ bit was checked by isandrk@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-08 15:45:16]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-08 16:50:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-08 16:50:16]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Ivan Šandrk, 2017-03-08 17:11:51]

Description was changed from

==========
Add sound volume to device attribute reporting

This CL adds another device attribute to the report which is uploaded to admin
console.

More context can be found by reading the design doc go/remote-audio-management

BUG=682792
==========

to

==========
Add sound volume to device attribute reporting

This CL adds another device attribute to the report which is uploaded to admin
console.

More context can be found by reading the design doc go/remote-audio-management

BUG=699589
==========

[Ivan Šandrk, 2017-03-09 13:27:51]

Patchset #2 (id:20001) has been deleted

[Ivan Šandrk, 2017-03-09 15:32:14]

The CQ bit was checked by isandrk@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-09 15:32:35]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Ivan Šandrk, 2017-03-09 15:32:37]

isandrk@chromium.org changed reviewers:
+ atwilson@chromium.org

[Ivan Šandrk, 2017-03-09 15:32:38]

Hey Drew, ptal!

[Ivan Šandrk, 2017-03-09 15:43:53]

isandrk@chromium.org changed reviewers:
+ achuith@chromium.org, isherman@chromium.org

[Ivan Šandrk, 2017-03-09 15:43:53]

Ilya: ptal at histograms

Achuith: ptal at chromeos/settings/

[Andrew T Wilson (Slow), 2017-03-09 15:56:34]

I think this CL gets much simpler (and removes a bunch of reviewers) if you just
include this along with the hardware_status updates. You don't need to include
all the extra policies/histograms/etc.

https://codereview.chromium.org/2736903004/diff/40001/chrome/browser/chromeos...
File chrome/browser/chromeos/policy/device_policy_decoder_chromeos.cc (right):

https://codereview.chromium.org/2736903004/diff/40001/chrome/browser/chromeos...
chrome/browser/chromeos/policy/device_policy_decoder_chromeos.cc:496:
key::kReportSoundVolume, POLICY_LEVEL_MANDATORY,
I wouldn't build a separate control for this - just include this with
report_hardware_status()

https://codereview.chromium.org/2736903004/diff/40001/chrome/browser/chromeos...
File chrome/browser/chromeos/policy/device_status_collector.cc (right):

https://codereview.chromium.org/2736903004/diff/40001/chrome/browser/chromeos...
chrome/browser/chromeos/policy/device_status_collector.cc:992:
status->set_system_ram_total(base::SysInfo::AmountOfPhysicalMemory());
I'd include the volume reporting here.

https://codereview.chromium.org/2736903004/diff/40001/chrome/browser/chromeos...
File chrome/browser/chromeos/policy/device_status_collector.h (right):

https://codereview.chromium.org/2736903004/diff/40001/chrome/browser/chromeos...
chrome/browser/chromeos/policy/device_status_collector.h:300:
sound_volume_subscription_;
See my prev comment - probably makes sense to just include this with
hardware_status so no need for a separate setting to track

[Ivan Šandrk, 2017-03-09 16:11:16]

The CQ bit was checked by isandrk@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-09 16:11:55]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Ivan Šandrk, 2017-03-09 16:14:13]

Achuith, Ilya, I've removed you from the reviewers after the latest change.
Sorry for the spam and thanks for understanding :-)

Ivan

[Ivan Šandrk, 2017-03-09 16:14:41]

isandrk@chromium.org changed reviewers:
- achuith@chromium.org, isherman@chromium.org

[Ivan Šandrk, 2017-03-09 16:14:42]

Drew ptal again!

[achuithb, 2017-03-09 16:46:26]

On 2017/03/09 16:14:13, Ivan Šandrk wrote:
> Achuith, Ilya, I've removed you from the reviewers after the latest change.
> Sorry for the spam and thanks for understanding :-)
> 
> Ivan

No worries, glad I didn't take a look before ;)

[commit-bot: I haz the power, 2017-03-09 17:03:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-09 17:03:21]

Dry run: This issue passed the CQ dry run.

[Andrew T Wilson (Slow), 2017-03-10 10:48:18]

lgtm, make sure to reach out to the server team about the proto change.

[Ivan Šandrk, 2017-03-10 10:56:28]

The CQ bit was checked by isandrk@chromium.org

[commit-bot: I haz the power, 2017-03-10 10:56:35]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-10 11:03:13]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1489143388196040,
"parent_rev": "afc56429f8182efa5b97cda6ba8bed9999469a46", "commit_rev":
"f4366520e5828318c92113012e02f1027779a792"}

[commit-bot: I haz the power, 2017-03-10 11:03:50]

Description was changed from

==========
Add sound volume to device attribute reporting

This CL adds another device attribute to the report which is uploaded to admin
console.

More context can be found by reading the design doc go/remote-audio-management

BUG=699589
==========

to

==========
Add sound volume to device attribute reporting

This CL adds another device attribute to the report which is uploaded to admin
console.

More context can be found by reading the design doc go/remote-audio-management

BUG=699589

Review-Url: https://codereview.chromium.org/2736903004
Cr-Commit-Position: refs/heads/master@{#456039}
Committed:
https://chromium.googlesource.com/chromium/src/+/f4366520e5828318c92113012e02...
==========

[commit-bot: I haz the power, 2017-03-10 11:03:53]

Committed patchset #3 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/f4366520e5828318c92113012e02...