Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(236)

Issue 2736873005: Merged: [build] Fix gyp files for building inspector (Closed)

Created:
3 years, 9 months ago by targos
Modified:
3 years, 8 months ago
Reviewers:
Michael Hablich
CC:
ulan, v8-merges_googlegroups.com, v8-reviews_googlegroups.com
Target Ref:
refs/pending/branch-heads/5.7
Project:
v8
Visibility:
Public.

Description

Merged: [build] Fix gyp files for building inspector Revision: c5c570f0c0dd638b59406c0d1eae0bca96fd6f0c NOTRY=true NOPRESUBMIT=true NOTREECHECKS=true R=hablich@chromium.org BUG=v8:6032 Review-Url: https://codereview.chromium.org/2736873005 Cr-Commit-Position: refs/branch-heads/5.7@{#162} Cr-Branched-From: 975e9a320b6eaf9f12280c35df98e013beb8f041-refs/heads/5.7.492@{#1} Cr-Branched-From: 8d76f0e3465a84bbf0bceab114900fbe75844e1f-refs/heads/master@{#42426} Committed: https://chromium.googlesource.com/v8/v8/+/4eb8f7ca0826b12b7c584e371894f7a432923fd2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -2 lines) Patch
M gypfiles/toolchain.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M src/inspector/inspector.gyp View 4 chunks +28 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
targos
3 years, 9 months ago (2017-03-08 19:44:14 UTC) #1
targos
3 years, 9 months ago (2017-03-08 19:48:21 UTC) #2
targos
ping
3 years, 9 months ago (2017-03-14 14:28:18 UTC) #3
Michael Hablich
On 2017/03/14 14:28:18, targos wrote: > ping Seems that slipped through. Sorry. lgtm
3 years, 8 months ago (2017-04-12 08:05:19 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2736873005/1
3 years, 8 months ago (2017-04-12 08:05:31 UTC) #6
commit-bot: I haz the power
3 years, 8 months ago (2017-04-12 08:07:02 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/4eb8f7ca0826b12b7c584e371894f7a4329...

Powered by Google App Engine
This is Rietveld 408576698