Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(348)

Issue 2736873004: Remove custom shortcut for Chromad (Closed)

Created:
3 years, 9 months ago by Roman Sorokin (ftl)
Modified:
3 years, 9 months ago
Reviewers:
Thiemo Nagel, achuithb
CC:
chromium-reviews, alemate+watch_chromium.org, achuith+watch_chromium.org, oshima+watch_chromium.org, davemoore+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove custom shortcut for Chromad Remove ctrl-alt-shift-a for the Active Directory enrollment flow. Let server decide type of enrollment. Also remove "--enable-ad" command line flag BUG=668455 TEST=manual Review-Url: https://codereview.chromium.org/2736873004 Cr-Commit-Position: refs/heads/master@{#458398} Committed: https://chromium.googlesource.com/chromium/src/+/9618887b3455dad36fabad59281659a02adeae26

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -33 lines) Patch
M chrome/browser/chromeos/login/ui/webui_login_view.cc View 2 chunks +0 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/policy/device_cloud_policy_initializer.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc View 2 chunks +0 lines, -13 lines 0 comments Download
M chromeos/chromeos_switches.h View 1 chunk +0 lines, -1 line 0 comments Download
M chromeos/chromeos_switches.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M ui/login/display_manager.js View 2 chunks +1 line, -5 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
Roman Sorokin (ftl)
Hey Achuith, Thiemo, PTAL.
3 years, 9 months ago (2017-03-08 11:04:50 UTC) #4
achuithb
lgtm
3 years, 9 months ago (2017-03-08 11:06:19 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2736873004/1
3 years, 9 months ago (2017-03-21 13:34:31 UTC) #9
Thiemo Nagel
Lgtm.
3 years, 9 months ago (2017-03-21 13:35:50 UTC) #10
commit-bot: I haz the power
3 years, 9 months ago (2017-03-21 14:13:12 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/9618887b3455dad36fabad592816...

Powered by Google App Engine
This is Rietveld 408576698