Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(571)

Unified Diff: chrome/browser/ui/views/media_router/media_router_ui_browsertest.cc

Issue 2736863002: Migrate the pref to always show the Cast icon (Closed)
Patch Set: Group ifdefs Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/prefs/browser_prefs.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/views/media_router/media_router_ui_browsertest.cc
diff --git a/chrome/browser/ui/views/media_router/media_router_ui_browsertest.cc b/chrome/browser/ui/views/media_router/media_router_ui_browsertest.cc
index a8133e709992dddac58c0d3ecbe8400023dda9fc..71f52fe1f0273ee5aaca62ed88cb51ccb4537cb5 100644
--- a/chrome/browser/ui/views/media_router/media_router_ui_browsertest.cc
+++ b/chrome/browser/ui/views/media_router/media_router_ui_browsertest.cc
@@ -7,6 +7,7 @@
#include "chrome/app/chrome_command_ids.h"
#include "chrome/browser/extensions/browser_action_test_util.h"
#include "chrome/browser/media/router/media_router_ui_service.h"
+#include "chrome/browser/prefs/browser_prefs.h"
#include "chrome/browser/renderer_context_menu/render_view_context_menu_test_util.h"
#include "chrome/browser/ui/browser.h"
#include "chrome/browser/ui/browser_commands.h"
@@ -32,6 +33,11 @@
#include "content/public/test/test_utils.h"
#include "ui/views/widget/widget.h"
+namespace {
+constexpr char kToolbarMigratedComponentActionStatus[] =
+ "toolbar_migrated_component_action_status";
+}
+
namespace media_router {
class MediaRouterUIBrowserTest : public InProcessBrowserTest {
@@ -116,6 +122,18 @@ class MediaRouterUIBrowserTest : public InProcessBrowserTest {
->app_menu_button();
}
+ // Sets the old preference to show the toolbar action icon to |always_show|,
+ // and migrates the preference.
+ void MigrateToolbarIconPref(bool always_show) {
+ {
+ DictionaryPrefUpdate update(browser()->profile()->GetPrefs(),
+ kToolbarMigratedComponentActionStatus);
+ update->SetBoolean(ComponentToolbarActionsFactory::kMediaRouterActionId,
+ always_show);
+ }
+ chrome::MigrateObsoleteProfilePrefs(browser()->profile());
+ }
+
protected:
ToolbarActionsBar* toolbar_actions_bar_ = nullptr;
@@ -351,4 +369,17 @@ IN_PROC_BROWSER_TEST_F(MediaRouterUIBrowserTest, UpdateActionLocation) {
toolbar_actions_bar_->IsActionVisibleOnMainBar(GetMediaRouterAction()));
}
+IN_PROC_BROWSER_TEST_F(MediaRouterUIBrowserTest, MigrateToolbarIconShownPref) {
+ MigrateToolbarIconPref(true);
+ EXPECT_TRUE(MediaRouterActionController::GetAlwaysShowActionPref(
+ browser()->profile()));
+}
+
+IN_PROC_BROWSER_TEST_F(MediaRouterUIBrowserTest,
+ MigrateToolbarIconUnshownPref) {
+ MigrateToolbarIconPref(false);
+ EXPECT_FALSE(MediaRouterActionController::GetAlwaysShowActionPref(
+ browser()->profile()));
+}
+
} // namespace media_router
« no previous file with comments | « chrome/browser/prefs/browser_prefs.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698