Migrate the pref to always show the Cast icon

chrome/browser/ui/views/media_router/media_router_ui_browsertest.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/bind.h"
 #include "base/threading/thread_task_runner_handle.h"
 #include "chrome/app/chrome_command_ids.h"
 #include "chrome/browser/extensions/browser_action_test_util.h"
 #include "chrome/browser/media/router/media_router_ui_service.h"
+#include "chrome/browser/prefs/browser_prefs.h"
 #include "chrome/browser/renderer_context_menu/render_view_context_menu_test_util.h"
 #include "chrome/browser/ui/browser.h"
 #include "chrome/browser/ui/browser_commands.h"
 #include "chrome/browser/ui/tabs/tab_strip_model.h"
 #include "chrome/browser/ui/toolbar/component_toolbar_actions_factory.h"
 #include "chrome/browser/ui/toolbar/media_router_action.h"
 #include "chrome/browser/ui/toolbar/media_router_action_controller.h"
 #include "chrome/browser/ui/toolbar/toolbar_action_view_delegate.h"
 #include "chrome/browser/ui/views/frame/browser_view.h"
 #include "chrome/browser/ui/views/toolbar/app_menu.h"
 #include "chrome/browser/ui/views/toolbar/app_menu_button.h"
 #include "chrome/browser/ui/views/toolbar/browser_actions_container.h"
 #include "chrome/browser/ui/views/toolbar/toolbar_action_view.h"
 #include "chrome/browser/ui/views/toolbar/toolbar_view.h"
 #include "chrome/browser/ui/webui/media_router/media_router_dialog_controller_impl.h"
 #include "chrome/common/url_constants.h"
 #include "chrome/test/base/in_process_browser_test.h"
 #include "chrome/test/base/ui_test_utils.h"
 #include "content/public/browser/navigation_entry.h"
 #include "content/public/browser/web_contents.h"
 #include "content/public/common/context_menu_params.h"
 #include "content/public/test/test_navigation_observer.h"
 #include "content/public/test/test_utils.h"
 #include "ui/views/widget/widget.h"
 
+namespace {
+constexpr char kToolbarMigratedComponentActionStatus[] =
+    "toolbar_migrated_component_action_status";
+}
+
 namespace media_router {
 
 class MediaRouterUIBrowserTest : public InProcessBrowserTest {
  public:
   MediaRouterUIBrowserTest()
       : issue_(IssueInfo("title notification",
                          IssueInfo::Action::DISMISS,
                          IssueInfo::Severity::NOTIFICATION)) {}
   ~MediaRouterUIBrowserTest() override {}
 
@@ skipping 64 matching lines @@
     MediaRouterActionController::SetAlwaysShowActionPref(browser()->profile(),
                                                          always_show);
   }
 
   AppMenuButton* GetAppMenuButton() {
     return BrowserView::GetBrowserViewForBrowser(browser())
         ->toolbar()
         ->app_menu_button();
   }
 
+  // Sets the old preference to show the toolbar action icon to |always_show|,
+  // and migrates the preference.
+  void MigrateToolbarIconPref(bool always_show) {
+    {
+      DictionaryPrefUpdate update(browser()->profile()->GetPrefs(),
+                                  kToolbarMigratedComponentActionStatus);
+      update->SetBoolean(ComponentToolbarActionsFactory::kMediaRouterActionId,
+                         always_show);
+    }
+    chrome::MigrateObsoleteProfilePrefs(browser()->profile());
+  }
+
  protected:
   ToolbarActionsBar* toolbar_actions_bar_ = nullptr;
 
   Issue issue_;
 
   // A vector of MediaRoutes that includes a local route.
   std::vector<MediaRoute> routes_;
 
   MediaRouterActionController* action_controller_ = nullptr;
 };
@@ skipping 215 matching lines @@
   // The action should get hidden in the overflow menu.
   EXPECT_FALSE(
       toolbar_actions_bar_->IsActionVisibleOnMainBar(GetMediaRouterAction()));
   GetActionContextMenu()->ActivatedAt(command_index);
 
   // The action should be back on the main bar.
   EXPECT_TRUE(
       toolbar_actions_bar_->IsActionVisibleOnMainBar(GetMediaRouterAction()));
 }
 
+IN_PROC_BROWSER_TEST_F(MediaRouterUIBrowserTest, MigrateToolbarIconShownPref) {
+  MigrateToolbarIconPref(true);
+  EXPECT_TRUE(MediaRouterActionController::GetAlwaysShowActionPref(
+      browser()->profile()));
+}
+
+IN_PROC_BROWSER_TEST_F(MediaRouterUIBrowserTest,
+                       MigrateToolbarIconUnshownPref) {
+  MigrateToolbarIconPref(false);
+  EXPECT_FALSE(MediaRouterActionController::GetAlwaysShowActionPref(
+      browser()->profile()));
+}
+
 }  // namespace media_router