third_party/WebKit/Source/core/html/shadow/MediaControls.h - Issue 2736853003: Media: fix memory leak because of the document holding on an EventListener.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/shadow/MediaControls.h

Issue 2736853003: Media: fix memory leak because of the document holding on an EventListener. (Closed)

Patch Set: Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/html/shadow/MediaControls.h

diff --git a/third_party/WebKit/Source/core/html/shadow/MediaControls.h b/third_party/WebKit/Source/core/html/shadow/MediaControls.h

index b2046b6cbf97cd441b9544e5aaa4bb1c7126c58c..4d04fc60e4f9e5605b3bba381c8c5dd22e96cc17 100644

--- a/third_party/WebKit/Source/core/html/shadow/MediaControls.h

+++ b/third_party/WebKit/Source/core/html/shadow/MediaControls.h

@@ -159,6 +159,8 @@ class CORE_EXPORT MediaControls final : public HTMLDivElement {

bool containsRelatedTarget(Event*);

// Methods called by MediaControlsMediaEventListener.

+ void onInsertedIntoDocument();

+ void onRemovedFromDocument();

void onVolumeChange();

void onFocusIn();

void onTimeUpdate();