Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Side by Side Diff: third_party/WebKit/Source/core/html/shadow/MediaControls.h

Issue 2736853003: Media: fix memory leak because of the document holding on an EventListener. (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2011, 2012 Apple Inc. All rights reserved. 2 * Copyright (C) 2011, 2012 Apple Inc. All rights reserved.
3 * Copyright (C) 2011, 2012 Google Inc. All rights reserved. 3 * Copyright (C) 2011, 2012 Google Inc. All rights reserved.
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions 6 * modification, are permitted provided that the following conditions
7 * are met: 7 * are met:
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 141 matching lines...) Expand 10 before | Expand all | Expand 10 after
152 // do fit. This requires that m_panelWidth is current. 152 // do fit. This requires that m_panelWidth is current.
153 void computeWhichControlsFit(); 153 void computeWhichControlsFit();
154 154
155 // Node 155 // Node
156 bool isMediaControls() const override { return true; } 156 bool isMediaControls() const override { return true; }
157 bool willRespondToMouseMoveEvents() override { return true; } 157 bool willRespondToMouseMoveEvents() override { return true; }
158 void defaultEventHandler(Event*) override; 158 void defaultEventHandler(Event*) override;
159 bool containsRelatedTarget(Event*); 159 bool containsRelatedTarget(Event*);
160 160
161 // Methods called by MediaControlsMediaEventListener. 161 // Methods called by MediaControlsMediaEventListener.
162 void onInsertedIntoDocument();
163 void onRemovedFromDocument();
162 void onVolumeChange(); 164 void onVolumeChange();
163 void onFocusIn(); 165 void onFocusIn();
164 void onTimeUpdate(); 166 void onTimeUpdate();
165 void onDurationChange(); 167 void onDurationChange();
166 void onPlay(); 168 void onPlay();
167 void onPause(); 169 void onPause();
168 void onTextTracksAddedOrRemoved(); 170 void onTextTracksAddedOrRemoved();
169 void onTextTracksChanged(); 171 void onTextTracksChanged();
170 void onError(); 172 void onError();
171 void onLoadedMetadata(); 173 void onLoadedMetadata();
(...skipping 42 matching lines...) Expand 10 before | Expand all | Expand 10 after
214 int m_panelWidth; 216 int m_panelWidth;
215 217
216 bool m_keepShowingUntilTimerFires : 1; 218 bool m_keepShowingUntilTimerFires : 1;
217 }; 219 };
218 220
219 DEFINE_ELEMENT_TYPE_CASTS(MediaControls, isMediaControls()); 221 DEFINE_ELEMENT_TYPE_CASTS(MediaControls, isMediaControls());
220 222
221 } // namespace blink 223 } // namespace blink
222 224
223 #endif 225 #endif
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/BUILD.gn ('k') | third_party/WebKit/Source/core/html/shadow/MediaControls.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698