chrome/browser/android/offline_pages/evaluation/offline_page_evaluation_bridge.cc - Issue 2736843002: Fix the Download Notifications for Offline Pages to indicate bytes loaded.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/android/offline_pages/evaluation/offline_page_evaluation_bridge.cc

Issue 2736843002: Fix the Download Notifications for Offline Pages to indicate bytes loaded. (Closed)

Patch Set: more fixes to more tests. Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/android/offline_pages/evaluation/offline_page_evaluation_bridge.h ('k') | chrome/browser/android/offline_pages/prerendering_offliner.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/android/offline_pages/evaluation/offline_page_evaluation_bridge.cc

diff --git a/chrome/browser/android/offline_pages/evaluation/offline_page_evaluation_bridge.cc b/chrome/browser/android/offline_pages/evaluation/offline_page_evaluation_bridge.cc

index db1d635c45bc1518ffb5aa19e55d14b726e71729..fdedb86f5ef0fc77228ae577caceed04ed7a9cbb 100644

--- a/chrome/browser/android/offline_pages/evaluation/offline_page_evaluation_bridge.cc

+++ b/chrome/browser/android/offline_pages/evaluation/offline_page_evaluation_bridge.cc

@@ -301,6 +301,10 @@ void OfflinePageEvaluationBridge::OnChanged(const SavePageRequest& request) {

env, obj, ToJavaSavePageRequest(env, request));

}

+void OfflinePageEvaluationBridge::OnNetworkProgress(

+ const SavePageRequest& request,

+ int64_t received_bytes) {}

void OfflinePageEvaluationBridge::CustomLog(const std::string& message) {

JNIEnv* env = base::android::AttachCurrentThread();

ScopedJavaLocalRef<jobject> obj = weak_java_ref_.get(env);