Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Side by Side Diff: chrome/browser/android/offline_pages/evaluation/offline_page_evaluation_bridge.cc

Issue 2736843002: Fix the Download Notifications for Offline Pages to indicate bytes loaded. (Closed)
Patch Set: more fixes to more tests. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/android/offline_pages/evaluation/offline_page_evaluatio n_bridge.h" 5 #include "chrome/browser/android/offline_pages/evaluation/offline_page_evaluatio n_bridge.h"
6 6
7 #include "base/android/callback_android.h" 7 #include "base/android/callback_android.h"
8 #include "base/android/jni_android.h" 8 #include "base/android/jni_android.h"
9 #include "base/android/jni_array.h" 9 #include "base/android/jni_array.h"
10 #include "base/android/jni_string.h" 10 #include "base/android/jni_string.h"
(...skipping 283 matching lines...) Expand 10 before | Expand all | Expand 10 after
294 294
295 void OfflinePageEvaluationBridge::OnChanged(const SavePageRequest& request) { 295 void OfflinePageEvaluationBridge::OnChanged(const SavePageRequest& request) {
296 JNIEnv* env = base::android::AttachCurrentThread(); 296 JNIEnv* env = base::android::AttachCurrentThread();
297 ScopedJavaLocalRef<jobject> obj = weak_java_ref_.get(env); 297 ScopedJavaLocalRef<jobject> obj = weak_java_ref_.get(env);
298 if (obj.is_null()) 298 if (obj.is_null())
299 return; 299 return;
300 Java_OfflinePageEvaluationBridge_savePageRequestChanged( 300 Java_OfflinePageEvaluationBridge_savePageRequestChanged(
301 env, obj, ToJavaSavePageRequest(env, request)); 301 env, obj, ToJavaSavePageRequest(env, request));
302 } 302 }
303 303
304 void OfflinePageEvaluationBridge::OnNetworkProgress(
305 const SavePageRequest& request,
306 int64_t received_bytes) {}
307
304 void OfflinePageEvaluationBridge::CustomLog(const std::string& message) { 308 void OfflinePageEvaluationBridge::CustomLog(const std::string& message) {
305 JNIEnv* env = base::android::AttachCurrentThread(); 309 JNIEnv* env = base::android::AttachCurrentThread();
306 ScopedJavaLocalRef<jobject> obj = weak_java_ref_.get(env); 310 ScopedJavaLocalRef<jobject> obj = weak_java_ref_.get(env);
307 if (obj.is_null()) 311 if (obj.is_null())
308 return; 312 return;
309 Java_OfflinePageEvaluationBridge_log(env, obj, 313 Java_OfflinePageEvaluationBridge_log(env, obj,
310 ConvertUTF8ToJavaString(env, kNativeTag), 314 ConvertUTF8ToJavaString(env, kNativeTag),
311 ConvertUTF8ToJavaString(env, message)); 315 ConvertUTF8ToJavaString(env, message));
312 } 316 }
313 317
(...skipping 68 matching lines...) Expand 10 before | Expand all | Expand 10 after
382 return; 386 return;
383 JNIEnv* env = base::android::AttachCurrentThread(); 387 JNIEnv* env = base::android::AttachCurrentThread();
384 ScopedJavaLocalRef<jobject> obj = weak_java_ref_.get(env); 388 ScopedJavaLocalRef<jobject> obj = weak_java_ref_.get(env);
385 if (obj.is_null()) 389 if (obj.is_null())
386 return; 390 return;
387 Java_OfflinePageEvaluationBridge_offlinePageModelLoaded(env, obj); 391 Java_OfflinePageEvaluationBridge_offlinePageModelLoaded(env, obj);
388 } 392 }
389 393
390 } // namespace android 394 } // namespace android
391 } // namespace offline_pages 395 } // namespace offline_pages
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698