Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(420)

Issue 2736823002: Move tests in editing/spelling for marker appearance to paint/spellmarkers (Closed)

Created:
3 years, 9 months ago by Xiaocheng
Modified:
3 years, 9 months ago
CC:
blink-reviews, chromium-reviews, mac-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move tests in editing/spelling for marker appearance to paint/spellmarkers The follow tests verify appearance of spelling/grammar markers, but do not verify Blink's spell checker: - editing/spelling/inline_spelling_markers.html - editing/spelling/inline-spelling-markers-hidpi.html - editing/spelling/inline-spelling-markers-hidpi-composited.html - editing/spelling/grammar-markers.html - editing/spelling/grammar-markers-hidpi.html Hence, this patch moves them to paint/spellmarkers. BUG=698890 Review-Url: https://codereview.chromium.org/2736823002 Cr-Commit-Position: refs/heads/master@{#455071} Committed: https://chromium.googlesource.com/chromium/src/+/a79e6ad57d1f1e019d62e9d0e990dbdd25177a0a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+-19 lines, -621 lines) Patch
M third_party/WebKit/LayoutTests/FlagExpectations/root-layer-scrolls View 2 chunks +1 line, -1 line 0 comments Download
D third_party/WebKit/LayoutTests/editing/spelling/grammar-markers.html View 1 chunk +0 lines, -21 lines 0 comments Download
D third_party/WebKit/LayoutTests/editing/spelling/grammar-markers-hidpi.html View 1 chunk +0 lines, -28 lines 0 comments Download
D third_party/WebKit/LayoutTests/editing/spelling/inline-spelling-markers-hidpi.html View 1 chunk +0 lines, -84 lines 0 comments Download
D third_party/WebKit/LayoutTests/editing/spelling/inline-spelling-markers-hidpi-composited.html View 1 chunk +0 lines, -83 lines 0 comments Download
D third_party/WebKit/LayoutTests/editing/spelling/inline_spelling_markers.html View 1 chunk +0 lines, -79 lines 0 comments Download
A + third_party/WebKit/LayoutTests/paint/spellmarkers/grammar-markers.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/paint/spellmarkers/grammar-markers-hidpi.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/paint/spellmarkers/inline-spelling-markers-hidpi.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/paint/spellmarkers/inline-spelling-markers-hidpi-composited.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/paint/spellmarkers/inline_spelling_markers.html View 0 chunks +-1 lines, --1 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/editing/spelling/grammar-markers-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/editing/spelling/grammar-markers-expected.txt View 1 chunk +0 lines, -8 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/editing/spelling/grammar-markers-hidpi-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/editing/spelling/grammar-markers-hidpi-expected.txt View 1 chunk +0 lines, -8 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/editing/spelling/inline-spelling-markers-hidpi-composited-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/editing/spelling/inline-spelling-markers-hidpi-composited-expected.txt View 1 chunk +0 lines, -33 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/editing/spelling/inline-spelling-markers-hidpi-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/editing/spelling/inline-spelling-markers-hidpi-expected.txt View 1 chunk +0 lines, -33 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/editing/spelling/inline_spelling_markers-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/editing/spelling/inline_spelling_markers-expected.txt View 1 chunk +0 lines, -33 lines 0 comments Download
A + third_party/WebKit/LayoutTests/platform/linux/paint/spellmarkers/grammar-markers-expected.png View Binary file 0 comments Download
A + third_party/WebKit/LayoutTests/platform/linux/paint/spellmarkers/grammar-markers-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/platform/linux/paint/spellmarkers/grammar-markers-hidpi-expected.png View Binary file 0 comments Download
A + third_party/WebKit/LayoutTests/platform/linux/paint/spellmarkers/grammar-markers-hidpi-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/platform/linux/paint/spellmarkers/inline-spelling-markers-hidpi-composited-expected.png View Binary file 0 comments Download
A + third_party/WebKit/LayoutTests/platform/linux/paint/spellmarkers/inline-spelling-markers-hidpi-composited-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/platform/linux/paint/spellmarkers/inline-spelling-markers-hidpi-expected.png View Binary file 0 comments Download
A + third_party/WebKit/LayoutTests/platform/linux/paint/spellmarkers/inline-spelling-markers-hidpi-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/platform/linux/paint/spellmarkers/inline_spelling_markers-expected.png View Binary file 0 comments Download
A + third_party/WebKit/LayoutTests/platform/linux/paint/spellmarkers/inline_spelling_markers-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/editing/spelling/grammar-markers-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/editing/spelling/grammar-markers-expected.txt View 1 chunk +0 lines, -8 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/editing/spelling/grammar-markers-hidpi-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/editing/spelling/grammar-markers-hidpi-expected.txt View 1 chunk +0 lines, -8 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/editing/spelling/inline-spelling-markers-hidpi-composited-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/editing/spelling/inline-spelling-markers-hidpi-composited-expected.txt View 1 chunk +0 lines, -33 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/editing/spelling/inline-spelling-markers-hidpi-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/editing/spelling/inline-spelling-markers-hidpi-expected.txt View 1 chunk +0 lines, -33 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/editing/spelling/inline_spelling_markers-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/editing/spelling/inline_spelling_markers-expected.txt View 1 chunk +0 lines, -33 lines 0 comments Download
A + third_party/WebKit/LayoutTests/platform/mac/paint/spellmarkers/grammar-markers-expected.png View Binary file 0 comments Download
A + third_party/WebKit/LayoutTests/platform/mac/paint/spellmarkers/grammar-markers-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/platform/mac/paint/spellmarkers/grammar-markers-hidpi-expected.png View Binary file 0 comments Download
A + third_party/WebKit/LayoutTests/platform/mac/paint/spellmarkers/grammar-markers-hidpi-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/platform/mac/paint/spellmarkers/inline-spelling-markers-hidpi-composited-expected.png View Binary file 0 comments Download
A + third_party/WebKit/LayoutTests/platform/mac/paint/spellmarkers/inline-spelling-markers-hidpi-composited-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/platform/mac/paint/spellmarkers/inline-spelling-markers-hidpi-expected.png View Binary file 0 comments Download
A + third_party/WebKit/LayoutTests/platform/mac/paint/spellmarkers/inline-spelling-markers-hidpi-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/platform/mac/paint/spellmarkers/inline_spelling_markers-expected.png View Binary file 0 comments Download
A + third_party/WebKit/LayoutTests/platform/mac/paint/spellmarkers/inline_spelling_markers-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/editing/spelling/grammar-markers-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/editing/spelling/grammar-markers-expected.txt View 1 chunk +0 lines, -8 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/editing/spelling/grammar-markers-hidpi-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/editing/spelling/grammar-markers-hidpi-expected.txt View 1 chunk +0 lines, -8 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/editing/spelling/inline-spelling-markers-hidpi-composited-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/editing/spelling/inline-spelling-markers-hidpi-composited-expected.txt View 1 chunk +0 lines, -33 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/editing/spelling/inline-spelling-markers-hidpi-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/editing/spelling/inline-spelling-markers-hidpi-expected.txt View 1 chunk +0 lines, -33 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/editing/spelling/inline_spelling_markers-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/editing/spelling/inline_spelling_markers-expected.txt View 1 chunk +0 lines, -33 lines 0 comments Download
A + third_party/WebKit/LayoutTests/platform/win/paint/spellmarkers/grammar-markers-expected.png View Binary file 0 comments Download
A + third_party/WebKit/LayoutTests/platform/win/paint/spellmarkers/grammar-markers-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/platform/win/paint/spellmarkers/grammar-markers-hidpi-expected.png View Binary file 0 comments Download
A + third_party/WebKit/LayoutTests/platform/win/paint/spellmarkers/grammar-markers-hidpi-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/platform/win/paint/spellmarkers/inline-spelling-markers-hidpi-composited-expected.png View Binary file 0 comments Download
A + third_party/WebKit/LayoutTests/platform/win/paint/spellmarkers/inline-spelling-markers-hidpi-composited-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/platform/win/paint/spellmarkers/inline-spelling-markers-hidpi-expected.png View Binary file 0 comments Download
A + third_party/WebKit/LayoutTests/platform/win/paint/spellmarkers/inline-spelling-markers-hidpi-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/platform/win/paint/spellmarkers/inline_spelling_markers-expected.png View Binary file 0 comments Download
A + third_party/WebKit/LayoutTests/platform/win/paint/spellmarkers/inline_spelling_markers-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
Xiaocheng
PTAL.
3 years, 9 months ago (2017-03-06 23:40:58 UTC) #5
Xiaocheng
+fmalita
3 years, 9 months ago (2017-03-06 23:59:26 UTC) #7
Stephen Chennney
Thanks. lgtm.
3 years, 9 months ago (2017-03-07 14:44:48 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2736823002/1
3 years, 9 months ago (2017-03-07 14:45:37 UTC) #12
commit-bot: I haz the power
3 years, 9 months ago (2017-03-07 14:52:30 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/a79e6ad57d1f1e019d62e9d0e990...

Powered by Google App Engine
This is Rietveld 408576698