Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(217)

Issue 2736803002: MD Settings: Stop using <option>'s |selected| HTML attribute in bindings. (Closed)

Created:
3 years, 9 months ago by dpapad
Modified:
3 years, 9 months ago
Reviewers:
tommycli
CC:
arv+watch_chromium.org, chromium-reviews, dbeam+watch-settings_chromium.org, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, stevenjb+watch-md-settings_chromium.org, Dan Beam
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: Stop using <option>'s |selected| HTML attribute in bindings. The selected HTML attribute can be ignored if the <option> is in a "dirty" state. Use the IDL |selected| attribute instead which is always respected. https://html.spec.whatwg.org/multipage/forms.html#attr-option-selected This fixes a corner case where the search engines <select> is showing the wrong <option> as selected. BUG=698189 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2736803002 Cr-Commit-Position: refs/heads/master@{#455219} Committed: https://chromium.googlesource.com/chromium/src/+/906adfec35ab217d2be4f851cbefb85400d43eab

Patch Set 1 #

Patch Set 2 : Change selected. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M chrome/browser/resources/settings/appearance_page/appearance_page.html View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/settings/device_page/power.html View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/settings/device_page/stylus.html View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/settings/search_page/search_page.html View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (10 generated)
dpapad
3 years, 9 months ago (2017-03-07 04:09:01 UTC) #8
tommycli
lgtm
3 years, 9 months ago (2017-03-07 18:19:06 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2736803002/20001
3 years, 9 months ago (2017-03-07 19:51:20 UTC) #11
commit-bot: I haz the power
3 years, 9 months ago (2017-03-07 21:08:12 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/906adfec35ab217d2be4f851cbef...

Powered by Google App Engine
This is Rietveld 408576698