Issue 27368003: Add page visibility observer for Geolocation

Issue 27368003: Add page visibility observer for Geolocation (Closed)

Created:
7 years, 2 months ago by Inactive

Modified:
7 years, 2 months ago

Reviewers:
abarth-chromium

CC:
blink-reviews, Michael van Ouwerkerk

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Add page visibility observer for Geolocation Add page visibility observer for Geolocation so that we stop firing GPS events to pages that are not visible, in order to save battery life. R=abarth BUG=112938 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=159723

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix nit #

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+137 lines, -6 lines)			Patch
A	LayoutTests/fast/dom/Geolocation/watchPosition-page-visibility.html	View		1 chunk	+84 lines, -0 lines	0 comments	Download
A	LayoutTests/fast/dom/Geolocation/watchPosition-page-visibility-expected.txt	View		1 chunk	+33 lines, -0 lines	0 comments	Download
M	Source/modules/geolocation/GeolocationController.h	View	1	4 chunks	+5 lines, -2 lines	0 comments	Download
M	Source/modules/geolocation/GeolocationController.cpp	View	1	4 chunks	+15 lines, -4 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

abarth-chromium

lgtm https://codereview.chromium.org/27368003/diff/1/Source/modules/geolocation/GeolocationController.cpp File Source/modules/geolocation/GeolocationController.cpp (right): https://codereview.chromium.org/27368003/diff/1/Source/modules/geolocation/GeolocationController.cpp#newcode39 Source/modules/geolocation/GeolocationController.cpp:39: , m_page(page) Can we delete m_page and just ...

7 years, 2 months ago (2013-10-15 20:57:50 UTC) #2

Inactive

https://codereview.chromium.org/27368003/diff/1/Source/modules/geolocation/GeolocationController.cpp File Source/modules/geolocation/GeolocationController.cpp (right): https://codereview.chromium.org/27368003/diff/1/Source/modules/geolocation/GeolocationController.cpp#newcode39 Source/modules/geolocation/GeolocationController.cpp:39: , m_page(page) On 2013/10/15 20:57:50, abarth wrote: > Can ...

7 years, 2 months ago (2013-10-15 21:32:09 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/27368003/7001

7 years, 2 months ago (2013-10-15 21:34:13 UTC) #4

Message was sent while issue was closed.

Change committed as 159723

Expand Messages | Collapse Messages