Add page visibility observer for Geolocation

Source/modules/geolocation/GeolocationController.cpp

 /*
  * Copyright (C) 2009 Apple Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
@@ skipping 16 matching lines @@
 #include "modules/geolocation/GeolocationController.h"
 
 #include "core/inspector/InspectorInstrumentation.h"
 #include "modules/geolocation/GeolocationClient.h"
 #include "modules/geolocation/GeolocationError.h"
 #include "modules/geolocation/GeolocationPosition.h"
 
 namespace WebCore {
 
 GeolocationController::GeolocationController(Page* page, GeolocationClient* client)
-    : m_client(client)
+    : PageLifecycleObserver(page)
+    , m_client(client)
     , m_page(page)

[abarth-chromium, 2013/10/15 20:57:50]

Can we delete m_page and just use the one in PageLifecycleObserver?

[Inactive, 2013/10/15 21:32:09]

Done.

 {
 }
 
 GeolocationController::~GeolocationController()
 {
     ASSERT(m_observers.isEmpty());
 
     if (m_client)
         m_client->geolocationDestroyed();
 }
 
 PassOwnPtr<GeolocationController> GeolocationController::create(Page* page, GeolocationClient* client)
 {
     return adoptPtr(new GeolocationController(page, client));
 }
 
 void GeolocationController::addObserver(Geolocation* observer, bool enableHighAccuracy)
 {
     // This may be called multiple times with the same observer, though removeObserver()
     // is called only once with each.
     bool wasEmpty = m_observers.isEmpty();
     m_observers.add(observer);
     if (enableHighAccuracy)
         m_highAccuracyObservers.add(observer);
 
     if (m_client) {
         if (enableHighAccuracy)
             m_client->setEnableHighAccuracy(true);
-        if (wasEmpty)
+        if (wasEmpty && page()->visibilityState() == PageVisibilityStateVisible)
             m_client->startUpdating();
     }
 }
 
 void GeolocationController::removeObserver(Geolocation* observer)
 {
     if (!m_observers.contains(observer))
         return;
 
     m_observers.remove(observer);
@@ skipping 45 matching lines @@
 {
     if (m_lastPosition.get())
         return m_lastPosition.get();
 
     if (!m_client)
         return 0;
 
     return m_client->lastPosition();
 }
 
+void GeolocationController::pageVisibilityChanged()
+{
+    if (m_observers.isEmpty() || !m_client)
+        return;
+
+    if (page()->visibilityState() == PageVisibilityStateVisible)
+        m_client->startUpdating();
+    else
+        m_client->stopUpdating();
+}
+
 const char* GeolocationController::supplementName()
 {
     return "GeolocationController";
 }
 
 void provideGeolocationTo(Page* page, GeolocationClient* client)
 {
     Supplement<Page>::provideTo(page, GeolocationController::supplementName(), GeolocationController::create(page, client));
 }
 
 } // namespace WebCore