Chromium Code Reviews
DescriptionRevert of Force chooser bubbles to close synchronously. (patchset #3 id:40001 of https://codereview.chromium.org/2724903008/ )
Reason for revert:
Reverting this patchset because it was insufficiently tested and introduced a new bug.
Original issue's description:
> Force chooser bubbles to close synchronously.
>
> This fixes a potential use-after-free because UsbChooserController holds
> a raw pointer to the RenderFrameHost and so must be destroyed as part of
> RenderFrameHost destruction.
>
> BUG=697486
>
> Review-Url: https://codereview.chromium.org/2724903008
> Cr-Commit-Position: refs/heads/master@{#454989}
> Committed: https://chromium.googlesource.com/chromium/src/+/692db28a688889a7946b04debfd890673ae2269f
TBR=msw@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=697486, 698927
Review-Url: https://codereview.chromium.org/2736793003
Cr-Commit-Position: refs/heads/master@{#455086}
Committed: https://chromium.googlesource.com/chromium/src/+/5e296353d65aef23ed1b524a4c1b01e568f6c3cd
Patch Set 1 #
Messages
Total messages: 8 (4 generated)
|
||||||||||||||||||||||||||||