Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Issue 2736793003: Revert of Force chooser bubbles to close synchronously. (Closed)

Created:
3 years, 9 months ago by Reilly Grant (use Gerrit)
Modified:
3 years, 9 months ago
Reviewers:
msw
CC:
chromium-reviews, tfarina, markusheintz_, msramek+watch_chromium.org, raymes+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Force chooser bubbles to close synchronously. (patchset #3 id:40001 of https://codereview.chromium.org/2724903008/ ) Reason for revert: Reverting this patchset because it was insufficiently tested and introduced a new bug. Original issue's description: > Force chooser bubbles to close synchronously. > > This fixes a potential use-after-free because UsbChooserController holds > a raw pointer to the RenderFrameHost and so must be destroyed as part of > RenderFrameHost destruction. > > BUG=697486 > > Review-Url: https://codereview.chromium.org/2724903008 > Cr-Commit-Position: refs/heads/master@{#454989} > Committed: https://chromium.googlesource.com/chromium/src/+/692db28a688889a7946b04debfd890673ae2269f TBR=msw@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=697486, 698927 Review-Url: https://codereview.chromium.org/2736793003 Cr-Commit-Position: refs/heads/master@{#455086} Committed: https://chromium.googlesource.com/chromium/src/+/5e296353d65aef23ed1b524a4c1b01e568f6c3cd

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -33 lines) Patch
M chrome/browser/ui/views/website_settings/chooser_bubble_ui_view.h View 3 chunks +2 lines, -6 lines 0 comments Download
M chrome/browser/ui/views/website_settings/chooser_bubble_ui_view.cc View 2 chunks +17 lines, -27 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
Reilly Grant (use Gerrit)
Created Revert of Force chooser bubbles to close synchronously.
3 years, 9 months ago (2017-03-07 15:50:01 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2736793003/1
3 years, 9 months ago (2017-03-07 15:51:39 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/5e296353d65aef23ed1b524a4c1b01e568f6c3cd
3 years, 9 months ago (2017-03-07 16:07:05 UTC) #7
msw
3 years, 9 months ago (2017-03-07 18:31:39 UTC) #8
Message was sent while issue was closed.
lgtm - can you elaborate on the bug this introduced?

Powered by Google App Engine
This is Rietveld 408576698