Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 2736773004: Replace RELEASE_ASSERT with CHECK in core/svg/ (Closed)

Created:
3 years, 9 months ago by mrunal
Modified:
3 years, 9 months ago
Reviewers:
tkent, fs
CC:
darktears, blink-reviews, blink-reviews-animation_chromium.org, chromium-reviews, krit, Eric Willigers, fmalita+watch_chromium.org, fs, gyuyoung2, kouhei+svg_chromium.org, pdr+svgwatchlist_chromium.org, rjwright, rwlbuis, Stephen Chennney, shans
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Replace RELEASE_ASSERT with CHECK in core/svg/ BUG=697687 Review-Url: https://codereview.chromium.org/2736773004 Cr-Commit-Position: refs/heads/master@{#456931} Committed: https://chromium.googlesource.com/chromium/src/+/cf7da999a0c77771e582ed3e29e56c79027655a7

Patch Set 1 #

Patch Set 2 : Rebase on top of latest from master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M third_party/WebKit/Source/core/svg/animation/SMILTimeContainer.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/svg/graphics/SVGImage.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (9 generated)
mrunal
fs, PTAL.
3 years, 9 months ago (2017-03-14 22:01:58 UTC) #7
fs
lgtm
3 years, 9 months ago (2017-03-14 22:05:05 UTC) #8
tkent
lgtm
3 years, 9 months ago (2017-03-14 22:23:42 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2736773004/20001
3 years, 9 months ago (2017-03-14 22:24:27 UTC) #11
commit-bot: I haz the power
3 years, 9 months ago (2017-03-15 01:06:15 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/cf7da999a0c77771e582ed3e29e5...

Powered by Google App Engine
This is Rietveld 408576698