Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(153)

Issue 2736733004: Fix UKM crash. Add TODO for fixing this properly. (Closed)

Created:
3 years, 9 months ago by Alexei Svitkine (slow)
Modified:
3 years, 9 months ago
Reviewers:
Steven Holte
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix UKM crash. Add TODO for fixing this properly. BUG=698819, 695433 Review-Url: https://codereview.chromium.org/2736733004 Cr-Commit-Position: refs/heads/master@{#454998} Committed: https://chromium.googlesource.com/chromium/src/+/c88119049586f4a9e28fd8c2ba1fa7ccc25c335f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M components/ukm/ukm_service.cc View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 8 (4 generated)
Alexei Svitkine (slow)
3 years, 9 months ago (2017-03-06 20:00:40 UTC) #2
Steven Holte
lgtm
3 years, 9 months ago (2017-03-06 21:04:18 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2736733004/1
3 years, 9 months ago (2017-03-06 21:06:36 UTC) #5
commit-bot: I haz the power
3 years, 9 months ago (2017-03-06 23:38:03 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/c88119049586f4a9e28fd8c2ba1f...

Powered by Google App Engine
This is Rietveld 408576698