Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(364)

Issue 2736733003: Revert of Add CHECKs to try to narrow down cause of bad internal fields in Window DOM wrapper (Closed)

Created:
3 years, 9 months ago by dcheng
Modified:
3 years, 9 months ago
Reviewers:
haraken, jbroman
CC:
blink-reviews, blink-reviews-bindings_chromium.org, chromium-reviews, dcheng, kinuko+watch, mlamouri+watch-blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Add CHECKs to try to narrow down cause of bad internal fields in Window DOM wrapper (patchset #2 id:20001 of https://codereview.chromium.org/2736533002/ ) Reason for revert: Reverting debugging patch Original issue's description: > Add CHECKs to try to narrow down cause of bad internal fields in Window DOM wrapper > > BUG=696528 > > Review-Url: https://codereview.chromium.org/2736533002 > Cr-Commit-Position: refs/heads/master@{#454781} > Committed: https://chromium.googlesource.com/chromium/src/+/7cf0339964c7dcb8b77660a31bed2467b9f7cc3a TBR=jbroman@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=696528 Review-Url: https://codereview.chromium.org/2736733003 Cr-Commit-Position: refs/heads/master@{#454967} Committed: https://chromium.googlesource.com/chromium/src/+/1652d291e9cebc86b0b671c0d08b2a5964780da6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -50 lines) Patch
M third_party/WebKit/Source/bindings/core/v8/WindowProxy.cpp View 2 chunks +0 lines, -31 lines 0 comments Download
M third_party/WebKit/Source/web/WebRemoteFrameImpl.cpp View 3 chunks +3 lines, -19 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
dcheng
Created Revert of Add CHECKs to try to narrow down cause of bad internal fields ...
3 years, 9 months ago (2017-03-06 19:41:10 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2736733003/1
3 years, 9 months ago (2017-03-06 19:41:57 UTC) #3
haraken
LGTM
3 years, 9 months ago (2017-03-06 20:00:47 UTC) #4
commit-bot: I haz the power
3 years, 9 months ago (2017-03-06 21:40:23 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/1652d291e9cebc86b0b671c0d08b...

Powered by Google App Engine
This is Rietveld 408576698