Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(234)

Issue 2736723003: [profiler] In the web UI, make all the call tree models lazy. (Closed)

Created:
3 years, 9 months ago by Jarin
Modified:
3 years, 9 months ago
Reviewers:
Camillo Bruni
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[profiler] In the web UI, make all the call tree models lazy. Review-Url: https://codereview.chromium.org/2736723003 Cr-Commit-Position: refs/heads/master@{#43614} Committed: https://chromium.googlesource.com/v8/v8/+/3c63c40f3e61705ced8c4fadd7795eaf0920a9db

Patch Set 1 #

Patch Set 2 : Remove dead code #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -67 lines) Patch
M tools/profview/profile-utils.js View 1 4 chunks +59 lines, -67 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
Jarin
Could you take a look, please?
3 years, 9 months ago (2017-03-06 13:51:55 UTC) #2
Camillo Bruni
lgtm
3 years, 9 months ago (2017-03-06 14:28:34 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2736723003/20001
3 years, 9 months ago (2017-03-06 14:34:23 UTC) #5
commit-bot: I haz the power
3 years, 9 months ago (2017-03-06 14:59:47 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/3c63c40f3e61705ced8c4fadd7795eaf092...

Powered by Google App Engine
This is Rietveld 408576698