Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2736643003:
Remove FFmpegDemuxer DCHECKs that are handled via conditionals. (Closed)
|
Created:
3 years, 9 months ago by DaleCurtis Modified:
3 years, 9 months ago Reviewers:
tguilbert CC:
chromium-reviews, feature-media-reviews_chromium.org, posciak+watch_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionRemove FFmpegDemuxer DCHECKs that are handled via conditionals.
These are tripping up the fuzzer tests, so remove. Per the style
guide we should not have DCHECKs which we handle too.
BUG=698549
TEST=none
Review-Url: https://codereview.chromium.org/2736643003
Cr-Commit-Position: refs/heads/master@{#455156}
Committed: https://chromium.googlesource.com/chromium/src/+/86a0024f06be519a8dc10ce7d2fc6eea5971645f
Patch Set 1 : Improve comment. #
Messages
Total messages: 24 (14 generated)
dalecurtis@chromium.org changed reviewers: + tguilbert@chromium.org
Patchset #1 (id:1) has been deleted
The CQ bit was checked by dalecurtis@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
LGTM
The CQ bit was unchecked by dalecurtis@chromium.org
The CQ bit was checked by dalecurtis@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)
The CQ bit was checked by dalecurtis@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)
The CQ bit was checked by dalecurtis@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)
The CQ bit was checked by tguilbert@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1488907439640130,
"parent_rev": "0923c3f3b69d593eebb2b87c1270664879ca4e17", "commit_rev":
"86a0024f06be519a8dc10ce7d2fc6eea5971645f"}
Message was sent while issue was closed.
Description was changed from ========== Remove FFmpegDemuxer DCHECKs that are handled via conditionals. These are tripping up the fuzzer tests, so remove. Per the style guide we should not have DCHECKs which we handle too. BUG=698549 TEST=none ========== to ========== Remove FFmpegDemuxer DCHECKs that are handled via conditionals. These are tripping up the fuzzer tests, so remove. Per the style guide we should not have DCHECKs which we handle too. BUG=698549 TEST=none Review-Url: https://codereview.chromium.org/2736643003 Cr-Commit-Position: refs/heads/master@{#455156} Committed: https://chromium.googlesource.com/chromium/src/+/86a0024f06be519a8dc10ce7d2fc... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:20001) as https://chromium.googlesource.com/chromium/src/+/86a0024f06be519a8dc10ce7d2fc... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
