Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(552)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 273663002: Componentize bookmark_node_data_unittest.cc (Closed)

Created:
6 years, 7 months ago by sdefresne
Modified:
6 years, 7 months ago
Reviewers:
tfarina, sky
CC:
chromium-reviews, tfarina, browser-components-watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Componentize bookmark_node_data_unittest.cc - Uses ScopedTempDir to remove dependency on TestingProfile. - Uses test::TestBookmarkClient to remove dependency on MessageLoop, BookmarkModelFactory, TestingProfile, TestBrowserThreadBundle BUG=367836 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269573

Patch Set 1 #

Total comments: 3

Patch Set 2 : Addressing comments #

Patch Set 3 : Move bookmark_node_data_unittest.cc to components/boomarks/core/browser #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -327 lines) Patch
D chrome/browser/bookmarks/bookmark_node_data_unittest.cc View 1 chunk +0 lines, -294 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 2 2 chunks +0 lines, -2 lines 0 comments Download
A + components/bookmarks/core/browser/bookmark_node_data_unittest.cc View 1 2 11 chunks +33 lines, -31 lines 0 comments Download
M components/components_tests.gyp View 1 2 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
sdefresne
PTAL
6 years, 7 months ago (2014-05-07 17:32:28 UTC) #1
tfarina
https://codereview.chromium.org/273663002/diff/20001/components/bookmarks/core/test/bookmark_node_data_unittest.cc File components/bookmarks/core/test/bookmark_node_data_unittest.cc (right): https://codereview.chromium.org/273663002/diff/20001/components/bookmarks/core/test/bookmark_node_data_unittest.cc#newcode30 components/bookmarks/core/test/bookmark_node_data_unittest.cc:30: DCHECK(success); nice simplification. https://codereview.chromium.org/273663002/diff/20001/components/bookmarks/core/test/bookmark_node_data_unittest.cc#newcode40 components/bookmarks/core/test/bookmark_node_data_unittest.cc:40: base::FilePath GetProfilePath() const { ...
6 years, 7 months ago (2014-05-07 17:46:32 UTC) #2
sky
LGTM with the following change https://codereview.chromium.org/273663002/diff/20001/components/bookmarks/core/test/bookmark_node_data_unittest.cc File components/bookmarks/core/test/bookmark_node_data_unittest.cc (right): https://codereview.chromium.org/273663002/diff/20001/components/bookmarks/core/test/bookmark_node_data_unittest.cc#newcode30 components/bookmarks/core/test/bookmark_node_data_unittest.cc:30: DCHECK(success); DCHECK->ASSERT
6 years, 7 months ago (2014-05-07 20:06:00 UTC) #3
sdefresne
The CQ bit was checked by sdefresne@chromium.org
6 years, 7 months ago (2014-05-09 12:41:51 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sdefresne@chromium.org/273663002/100001
6 years, 7 months ago (2014-05-09 12:46:12 UTC) #5
sdefresne
The CQ bit was unchecked by sdefresne@chromium.org
6 years, 7 months ago (2014-05-09 13:51:10 UTC) #6
sdefresne
The CQ bit was checked by sdefresne@chromium.org
6 years, 7 months ago (2014-05-09 13:52:25 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sdefresne@chromium.org/273663002/120001
6 years, 7 months ago (2014-05-09 13:55:40 UTC) #8
commit-bot: I haz the power
6 years, 7 months ago (2014-05-10 12:07:46 UTC) #9
Message was sent while issue was closed. 
Change committed as 269573

Powered by Google App Engine
This is Rietveld 408576698