Componentize bookmark_node_data_unittest.cc

components/bookmarks/core/test/bookmark_node_data_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/basictypes.h"
+#include "base/files/scoped_temp_dir.h"
 #include "base/memory/scoped_ptr.h"
-#include "base/message_loop/message_loop.h"
 #include "base/strings/string16.h"
 #include "base/strings/utf_string_conversions.h"
-#include "chrome/browser/bookmarks/bookmark_model_factory.h"
-#include "chrome/test/base/testing_profile.h"
 #include "components/bookmarks/core/browser/bookmark_model.h"
 #include "components/bookmarks/core/browser/bookmark_node_data.h"
 #include "components/bookmarks/core/test/bookmark_test_helpers.h"
-#include "content/public/test/test_browser_thread_bundle.h"
+#include "components/bookmarks/core/test/test_bookmark_client.h"
 #include "testing/gtest/include/gtest/gtest.h"
 #include "ui/base/dragdrop/os_exchange_data.h"
 #include "ui/events/platform/platform_event_source.h"
 #include "url/gurl.h"
 
 using base::ASCIIToUTF16;
 
 class BookmarkNodeDataTest : public testing::Test {
  public:
-  BookmarkNodeDataTest() : model_(NULL) {}
+  BookmarkNodeDataTest() {}
 
   virtual void SetUp() OVERRIDE {
     event_source_ = ui::PlatformEventSource::CreateDefault();
-    profile_.reset(new TestingProfile);
-    profile_->SetID(L"id");
-    profile_->CreateBookmarkModel(false);
-    model_ = BookmarkModelFactory::GetForProfile(profile_.get());
-    test::WaitForBookmarkModelToLoad(model_);
+    model_ = client_.CreateModel(false).Pass();
+    test::WaitForBookmarkModelToLoad(model_.get());
+    bool success = profile_dir_.CreateUniqueTempDir();
+    DCHECK(success);

[tfarina, 2014/05/07 17:46:33]

nice simplification.

[sky, 2014/05/07 20:06:00]

DCHECK->ASSERT

   }
 
   virtual void TearDown() OVERRIDE {
-    profile_.reset();
+    model_.reset();
     event_source_.reset();
+    bool success = profile_dir_.Delete();
+    DCHECK(success);
   }
 
-  Profile* profile() { return profile_.get(); }
+  base::FilePath GetProfilePath() const { return profile_dir_.path(); }

[tfarina, 2014/05/07 17:46:33]

const base::FilePath& profile_path() const { return profile_dir_.path(); }

 
-  BookmarkModel* model() { return model_; }
+  BookmarkModel* model() { return model_.get(); }
 
  private:
-  content::TestBrowserThreadBundle thread_bundle_;
-  scoped_ptr<TestingProfile> profile_;
-  BookmarkModel* model_;
+  base::ScopedTempDir profile_dir_;
+  test::TestBookmarkClient client_;
+  scoped_ptr<BookmarkModel> model_;
   scoped_ptr<ui::PlatformEventSource> event_source_;
 
   DISALLOW_COPY_AND_ASSIGN(BookmarkNodeDataTest);
 };
 
 namespace {
 
 ui::OSExchangeData::Provider* CloneProvider(const ui::OSExchangeData& data) {
   return data.provider().Clone();
 }
@@ skipping 44 matching lines @@
   BookmarkNodeData drag_data(node);
   EXPECT_TRUE(drag_data.is_valid());
   ASSERT_EQ(1u, drag_data.elements.size());
   EXPECT_TRUE(drag_data.elements[0].is_url);
   EXPECT_EQ(url, drag_data.elements[0].url);
   EXPECT_EQ(title, drag_data.elements[0].title);
   EXPECT_EQ(node->date_added(), drag_data.elements[0].date_added);
   EXPECT_EQ(node->date_folder_modified(),
             drag_data.elements[0].date_folder_modified);
   ui::OSExchangeData data;
-  drag_data.Write(profile()->GetPath(), &data);
+  drag_data.Write(GetProfilePath(), &data);
 
   // Now read the data back in.
   ui::OSExchangeData data2(CloneProvider(data));
   BookmarkNodeData read_data;
   EXPECT_TRUE(read_data.Read(data2));
   EXPECT_TRUE(read_data.is_valid());
   ASSERT_EQ(1u, read_data.elements.size());
   EXPECT_TRUE(read_data.elements[0].is_url);
   EXPECT_EQ(url, read_data.elements[0].url);
   EXPECT_EQ(title, read_data.elements[0].title);
   EXPECT_TRUE(read_data.elements[0].date_added.is_null());
   EXPECT_TRUE(read_data.elements[0].date_folder_modified.is_null());
-  EXPECT_TRUE(read_data.GetFirstNode(model(), profile()->GetPath()) == node);
+  EXPECT_TRUE(read_data.GetFirstNode(model(), GetProfilePath()) == node);
 
   // Make sure asking for the node with a different profile returns NULL.
-  TestingProfile profile2;
-  EXPECT_TRUE(read_data.GetFirstNode(model(), profile2.GetPath()) == NULL);
+  base::ScopedTempDir other_profile_dir;
+  EXPECT_TRUE(other_profile_dir.CreateUniqueTempDir());
+  EXPECT_TRUE(read_data.GetFirstNode(model(), other_profile_dir.path()) ==
+              NULL);
 
   // Writing should also put the URL and title on the clipboard.
   GURL read_url;
   base::string16 read_title;
   EXPECT_TRUE(data2.GetURLAndTitle(
       ui::OSExchangeData::CONVERT_FILENAMES, &read_url, &read_title));
   EXPECT_EQ(url, read_url);
   EXPECT_EQ(title, read_title);
 }
 
 // Tests writing a folder to the clipboard.
 TEST_F(BookmarkNodeDataTest, Folder) {
   const BookmarkNode* root = model()->bookmark_bar_node();
   const BookmarkNode* g1 = model()->AddFolder(root, 0, ASCIIToUTF16("g1"));
   model()->AddFolder(g1, 0, ASCIIToUTF16("g11"));
   const BookmarkNode* g12 = model()->AddFolder(g1, 0, ASCIIToUTF16("g12"));
 
   BookmarkNodeData drag_data(g12);
   EXPECT_TRUE(drag_data.is_valid());
   ASSERT_EQ(1u, drag_data.elements.size());
   EXPECT_EQ(g12->GetTitle(), drag_data.elements[0].title);
   EXPECT_FALSE(drag_data.elements[0].is_url);
   EXPECT_EQ(g12->date_added(), drag_data.elements[0].date_added);
   EXPECT_EQ(g12->date_folder_modified(),
             drag_data.elements[0].date_folder_modified);
 
   ui::OSExchangeData data;
-  drag_data.Write(profile()->GetPath(), &data);
+  drag_data.Write(GetProfilePath(), &data);
 
   // Now read the data back in.
   ui::OSExchangeData data2(CloneProvider(data));
   BookmarkNodeData read_data;
   EXPECT_TRUE(read_data.Read(data2));
   EXPECT_TRUE(read_data.is_valid());
   ASSERT_EQ(1u, read_data.elements.size());
   EXPECT_EQ(g12->GetTitle(), read_data.elements[0].title);
   EXPECT_FALSE(read_data.elements[0].is_url);
   EXPECT_TRUE(read_data.elements[0].date_added.is_null());
   EXPECT_TRUE(read_data.elements[0].date_folder_modified.is_null());
 
   // We should get back the same node when asking for the same profile.
-  const BookmarkNode* r_g12 =
-      read_data.GetFirstNode(model(), profile()->GetPath());
+  const BookmarkNode* r_g12 = read_data.GetFirstNode(model(), GetProfilePath());
   EXPECT_TRUE(g12 == r_g12);
 
   // A different profile should return NULL for the node.
-  TestingProfile profile2;
-  EXPECT_TRUE(read_data.GetFirstNode(model(), profile2.GetPath()) == NULL);
+  base::ScopedTempDir other_profile_dir;
+  EXPECT_TRUE(other_profile_dir.CreateUniqueTempDir());
+  EXPECT_TRUE(read_data.GetFirstNode(model(), other_profile_dir.path()) ==
+              NULL);
 }
 
 // Tests reading/writing a folder with children.
 TEST_F(BookmarkNodeDataTest, FolderWithChild) {
   const BookmarkNode* root = model()->bookmark_bar_node();
   const BookmarkNode* folder = model()->AddFolder(root, 0, ASCIIToUTF16("g1"));
 
   GURL url(GURL("http://foo.com"));
   const base::string16 title(ASCIIToUTF16("blah2"));
 
   model()->AddURL(folder, 0, title, url);
 
   BookmarkNodeData drag_data(folder);
 
   ui::OSExchangeData data;
-  drag_data.Write(profile()->GetPath(), &data);
+  drag_data.Write(GetProfilePath(), &data);
 
   // Now read the data back in.
   ui::OSExchangeData data2(CloneProvider(data));
   BookmarkNodeData read_data;
   EXPECT_TRUE(read_data.Read(data2));
   ASSERT_EQ(1u, read_data.elements.size());
   ASSERT_EQ(1u, read_data.elements[0].children.size());
   const BookmarkNodeData::Element& read_child =
       read_data.elements[0].children[0];
 
   EXPECT_TRUE(read_child.is_url);
   EXPECT_EQ(title, read_child.title);
   EXPECT_EQ(url, read_child.url);
   EXPECT_TRUE(read_data.elements[0].date_added.is_null());
   EXPECT_TRUE(read_data.elements[0].date_folder_modified.is_null());
   EXPECT_TRUE(read_child.is_url);
 
   // And make sure we get the node back.
   const BookmarkNode* r_folder =
-      read_data.GetFirstNode(model(), profile()->GetPath());
+      read_data.GetFirstNode(model(), GetProfilePath());
   EXPECT_TRUE(folder == r_folder);
 }
 
 // Tests reading/writing of multiple nodes.
 TEST_F(BookmarkNodeDataTest, MultipleNodes) {
   const BookmarkNode* root = model()->bookmark_bar_node();
   const BookmarkNode* folder = model()->AddFolder(root, 0, ASCIIToUTF16("g1"));
 
   GURL url(GURL("http://foo.com"));
   const base::string16 title(ASCIIToUTF16("blah2"));
 
   const BookmarkNode* url_node = model()->AddURL(folder, 0, title, url);
 
   // Write the nodes to the clipboard.
   std::vector<const BookmarkNode*> nodes;
   nodes.push_back(folder);
   nodes.push_back(url_node);
   BookmarkNodeData drag_data(nodes);
   ui::OSExchangeData data;
-  drag_data.Write(profile()->GetPath(), &data);
+  drag_data.Write(GetProfilePath(), &data);
 
   // Read the data back in.
   ui::OSExchangeData data2(CloneProvider(data));
   BookmarkNodeData read_data;
   EXPECT_TRUE(read_data.Read(data2));
   EXPECT_TRUE(read_data.is_valid());
   ASSERT_EQ(2u, read_data.elements.size());
   ASSERT_EQ(1u, read_data.elements[0].children.size());
   EXPECT_TRUE(read_data.elements[0].date_added.is_null());
   EXPECT_TRUE(read_data.elements[0].date_folder_modified.is_null());
 
   const BookmarkNodeData::Element& read_folder = read_data.elements[0];
   EXPECT_FALSE(read_folder.is_url);
   EXPECT_EQ(ASCIIToUTF16("g1"), read_folder.title);
   EXPECT_EQ(1u, read_folder.children.size());
 
   const BookmarkNodeData::Element& read_url = read_data.elements[1];
   EXPECT_TRUE(read_url.is_url);
   EXPECT_EQ(title, read_url.title);
   EXPECT_EQ(0u, read_url.children.size());
 
   // And make sure we get the node back.
   std::vector<const BookmarkNode*> read_nodes =
-      read_data.GetNodes(model(), profile()->GetPath());
+      read_data.GetNodes(model(), GetProfilePath());
   ASSERT_EQ(2u, read_nodes.size());
   EXPECT_TRUE(read_nodes[0] == folder);
   EXPECT_TRUE(read_nodes[1] == url_node);
 
   // Asking for the first node should return NULL with more than one element
   // present.
-  EXPECT_TRUE(read_data.GetFirstNode(model(), profile()->GetPath()) == NULL);
+  EXPECT_TRUE(read_data.GetFirstNode(model(), GetProfilePath()) == NULL);
 }
 
 // Tests reading/writing of meta info.
 TEST_F(BookmarkNodeDataTest, MetaInfo) {
   // Create a node containing meta info.
   const BookmarkNode* node = model()->AddURL(model()->other_node(),
                                              0,
                                              ASCIIToUTF16("foo bar"),
                                              GURL("http://www.google.com"));
   model()->SetNodeMetaInfo(node, "somekey", "somevalue");
   model()->SetNodeMetaInfo(node, "someotherkey", "someothervalue");
 
   BookmarkNodeData node_data(node);
   ui::OSExchangeData data;
-  node_data.Write(profile()->GetPath(), &data);
+  node_data.Write(GetProfilePath(), &data);
 
   // Read the data back in.
   ui::OSExchangeData data2(CloneProvider(data));
   BookmarkNodeData read_data;
   EXPECT_TRUE(read_data.Read(data2));
   EXPECT_TRUE(read_data.is_valid());
   ASSERT_EQ(1u, read_data.elements.size());
 
   // Verify that the read data contains the same meta info.
   BookmarkNode::MetaInfoMap meta_info_map = read_data.elements[0].meta_info_map;
   EXPECT_EQ(2u, meta_info_map.size());
   EXPECT_EQ("somevalue", meta_info_map["somekey"]);
   EXPECT_EQ("someothervalue", meta_info_map["someotherkey"]);
 }