Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 2736613009: Initialize the download file with correct bytes_so_far value (Closed)

Created:
3 years, 9 months ago by qinmin
Modified:
3 years, 9 months ago
CC:
chromium-reviews, asanka, jam, darin-cc_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Initialize the download file with correct bytes_so_far value When parallel download is enabled, the bytes_so_far value is not equal to the offset in save_info. Get the information from received_slices_ instead. BUG=644352 Review-Url: https://codereview.chromium.org/2736613009 Cr-Commit-Position: refs/heads/master@{#455598} Committed: https://chromium.googlesource.com/chromium/src/+/bc81898122086cf8a510c854583eefee34c1f022

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -2 lines) Patch
M content/browser/download/download_file_impl.cc View 2 chunks +9 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
qinmin
PTAL
3 years, 9 months ago (2017-03-08 19:47:45 UTC) #2
David Trainor- moved to gerrit
lgtm
3 years, 9 months ago (2017-03-08 19:52:55 UTC) #4
xingliu
lgtm
3 years, 9 months ago (2017-03-08 21:48:32 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2736613009/20001
3 years, 9 months ago (2017-03-08 23:39:23 UTC) #11
commit-bot: I haz the power
3 years, 9 months ago (2017-03-08 23:46:26 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/bc81898122086cf8a510c854583e...

Powered by Google App Engine
This is Rietveld 408576698