Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(457)

Issue 2736593002: Update API to latest spec : Remove VRFrameData#timestamp (Closed)

Created:
3 years, 9 months ago by shaobo.yan
Modified:
3 years, 9 months ago
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, blink-reviews, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, feature-vr-reviews_chromium.org, haraken, darin (slow to review), hokein.wu_gmail.com
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update API to latest spec : Remove VRFrameData#timestamp According to latest WebVR Spec, there are several changes. Remove VRFrameData#timestamp is one of them. BUG=697167 Review-Url: https://codereview.chromium.org/2736593002 Cr-Commit-Position: refs/heads/master@{#455619} Committed: https://chromium.googlesource.com/chromium/src/+/f4b1ca9d2d930fad5daaf6291a7a41c2eb141465

Patch Set 1 #

Patch Set 2 : Update wpt test related file #

Patch Set 3 : Remove getFrameData_timestamp_update.html #

Patch Set 4 : update expected file #

Patch Set 5 : update idlharness-expected.txt test total num and pass num #

Patch Set 6 : Continue update test related files #

Patch Set 7 : modify mock-vr-service.js #

Messages

Total messages: 61 (42 generated)
shaobo.yan
This patch is the first patch to Update API based on latest WebVR Spec (2, ...
3 years, 9 months ago (2017-03-06 02:27:14 UTC) #2
mthiesse
vr_shell/ lgtm
3 years, 9 months ago (2017-03-06 15:28:23 UTC) #4
bajones
modules/vr LGTM
3 years, 9 months ago (2017-03-06 18:59:43 UTC) #5
bsheedy
I think this will cause the IDL test to fail unless you update the expectations ...
3 years, 9 months ago (2017-03-06 19:03:11 UTC) #6
bsheedy
On 2017/03/06 19:03:11, bsheedy wrote: > I think this will cause the IDL test to ...
3 years, 9 months ago (2017-03-06 19:05:24 UTC) #7
shaobo.yan
On 2017/03/06 19:05:24, bsheedy wrote: > On 2017/03/06 19:03:11, bsheedy wrote: > > I think ...
3 years, 9 months ago (2017-03-07 00:35:07 UTC) #10
bsheedy
On 2017/03/07 00:35:07, shaobo.yan wrote: > On 2017/03/06 19:05:24, bsheedy wrote: > > On 2017/03/06 ...
3 years, 9 months ago (2017-03-07 00:36:42 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2736593002/20001
3 years, 9 months ago (2017-03-07 01:47:09 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/379318)
3 years, 9 months ago (2017-03-07 01:55:59 UTC) #16
shaobo.yan
dcheng@: PTAL
3 years, 9 months ago (2017-03-07 02:10:59 UTC) #18
dcheng
rs lgtm for mojom changes
3 years, 9 months ago (2017-03-07 08:17:29 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2736593002/20001
3 years, 9 months ago (2017-03-07 08:37:24 UTC) #21
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/403784)
3 years, 9 months ago (2017-03-07 09:44:54 UTC) #23
shaobo.yan
According to bots result, delete getFrameData_timestamp_update.html test. bsheedy@: PTAL
3 years, 9 months ago (2017-03-07 10:22:16 UTC) #24
bsheedy
On 2017/03/07 10:22:16, shaobo.yan wrote: > According to bots result, delete getFrameData_timestamp_update.html test. > bsheedy@: ...
3 years, 9 months ago (2017-03-07 17:14:51 UTC) #37
shaobo.yan
On 2017/03/07 17:14:51, bsheedy wrote: > On 2017/03/07 10:22:16, shaobo.yan wrote: > > According to ...
3 years, 9 months ago (2017-03-08 08:12:04 UTC) #54
bsheedy
On 2017/03/08 08:12:04, shaobo.yan wrote: > On 2017/03/07 17:14:51, bsheedy wrote: > > On 2017/03/07 ...
3 years, 9 months ago (2017-03-08 17:17:47 UTC) #55
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2736593002/120001
3 years, 9 months ago (2017-03-09 00:44:10 UTC) #58
commit-bot: I haz the power
3 years, 9 months ago (2017-03-09 01:15:05 UTC) #61
Message was sent while issue was closed.
Committed patchset #7 (id:120001) as
https://chromium.googlesource.com/chromium/src/+/f4b1ca9d2d930fad5daaf6291a7a...

Powered by Google App Engine
This is Rietveld 408576698