Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(344)

Issue 2736433003: Clean up web bluetooth related code (Closed)

Created:
3 years, 9 months ago by juncai
Modified:
3 years, 9 months ago
Reviewers:
scheib, ortuno
CC:
blink-reviews, chromium-reviews, haraken, ortuno+watch_chromium.org, scheib+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Clean up web bluetooth related code This CL cleans up web bluetooth related code so that inside a C++ class, it uses member variable directly instead of using getter. BUG=None Review-Url: https://codereview.chromium.org/2736433003 Cr-Commit-Position: refs/heads/master@{#454929} Committed: https://chromium.googlesource.com/chromium/src/+/a232126aef7735e92f6f0ad9d805cc525159a2f3

Patch Set 1 : clean up web bluetooth related code #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -21 lines) Patch
M device/bluetooth/bluez/bluetooth_remote_gatt_characteristic_bluez.h View 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTCharacteristic.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTServer.cpp View 7 chunks +9 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTService.cpp View 6 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
juncai
Please take a look.
3 years, 9 months ago (2017-03-04 01:44:02 UTC) #4
ortuno
lgtm
3 years, 9 months ago (2017-03-06 09:16:24 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2736433003/1
3 years, 9 months ago (2017-03-06 18:43:22 UTC) #10
commit-bot: I haz the power
3 years, 9 months ago (2017-03-06 20:06:13 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/a232126aef7735e92f6f0ad9d805...

Powered by Google App Engine
This is Rietveld 408576698