Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(220)

Issue 2736433002: [chromedriver] Remove _CleanTmpDir and use $TMPDIR directly on bots. (Closed)

Created:
3 years, 9 months ago by samuong
Modified:
3 years, 9 months ago
Reviewers:
stgao
CC:
chromium-reviews, samuong+watch_chromium.org, iannucci
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[chromedriver] Remove _CleanTmpDir and use $TMPDIR directly on bots. Previously we were creating a subdirectory under $TMPDIR so that it could be easily cleaned up by _CleanTmpDir (see crbug.com/598366 for context). We'll be getting a new unique temp dir per build once crbug.com/697941 is fixed. This makes our _CleanTmpDir function redundant, so I'm removing it. BUG=697941 Review-Url: https://codereview.chromium.org/2736433002 Cr-Commit-Position: refs/heads/master@{#454969} Committed: https://chromium.googlesource.com/chromium/src/+/bb0e33882bce1a7dc0b1a2c27149909bb755052c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -23 lines) Patch
M chrome/test/chromedriver/run_buildbot_steps.py View 2 chunks +0 lines, -23 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2736433002/1
3 years, 9 months ago (2017-03-03 23:15:24 UTC) #3
stgao
lgtm
3 years, 9 months ago (2017-03-03 23:30:32 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2736433002/1
3 years, 9 months ago (2017-03-06 21:41:00 UTC) #9
commit-bot: I haz the power
3 years, 9 months ago (2017-03-06 21:54:26 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/bb0e33882bce1a7dc0b1a2c27149...

Powered by Google App Engine
This is Rietveld 408576698