Chromium Code Reviews Chromium Code Reviews
Issue 273643008:
New Layout Tests to verify grid container's margin don't collapse. (Closed)
Base URL: https://chromium.googlesource.com/chromium/blink.git@master| Index: LayoutTests/fast/css-grid-layout/grid-margins-not-collapse.html |
| diff --git a/LayoutTests/fast/css-grid-layout/grid-margins-not-collapse.html b/LayoutTests/fast/css-grid-layout/grid-margins-not-collapse.html |
| new file mode 100644 |
| index 0000000000000000000000000000000000000000..7fa611c6dca5c7903acf99d5b55469794b04efb3 |
| --- /dev/null |
| +++ b/LayoutTests/fast/css-grid-layout/grid-margins-not-collapse.html |
| @@ -0,0 +1,26 @@ |
| +<!DOCTYPE html> |
| +<html> |
|
ojan
2014/05/21 18:43:12
We usually leave out the <html><head> and <body> e
jfernandez
2014/05/22 14:40:46
I've removed those elements from the new patch. Ho
|
| +<link href="resources/grid.css" rel="stylesheet"> |
| +<head> |
| +<style> |
| +.basic { |
| + background-color: grey; |
| + height: 100px; |
| + margin-top: 50px; |
| +} |
| + |
| +.item { |
| + width: 50px; |
| + height: 50px; |
| + margin-top: 20px; |
| +} |
| +</style> |
| +</head> |
| +<body> |
| +<div>This test checks that the grid's margins do not collapse with the margins of its contents.</div> |
| +<div class="basic grid"> |
| + <div class="item firstRowFirstColumn"></div> |
|
ojan
2014/05/21 18:43:12
Please use consistent indentation (i.e. use 4 spac
jfernandez
2014/05/22 14:40:46
Done.
|
| +</div> |
| +</body> |
| +</html> |
| + |
