LayoutTests/fast/css-grid-layout/grid-margins-not-collapse.html - Issue 273643008: New Layout Tests to verify grid container's margin don't collapse.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/css-grid-layout/grid-margins-not-collapse.html

Issue 273643008: New Layout Tests to verify grid container's margin don't collapse. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <html>
	ojan 2014/05/21 18:43:12 We usually leave out the <html><head> and <body> e We usually leave out the <html><head> and <body> elements unless the test requires it. They just add noise. jfernandez 2014/05/22 14:40:46 I've removed those elements from the new patch. Ho Show quoted text On 2014/05/21 18:43:12, ojan wrote: > We usually leave out the <html><head> and <body> elements unless the test > requires it. They just add noise. I've removed those elements from the new patch. However, most of the tests in the css-grid folder have such elements.
	3 <link href="resources/grid.css" rel="stylesheet">

	4 <head>

	5 <style>

	6 .basic {

	7 background-color: grey;

	8 height: 100px;

	9 margin-top: 50px;

	10 }

	11

	12 .item {

	13 width: 50px;

	14 height: 50px;

	15 margin-top: 20px;

	16 }

	17 </style>

	18 </head>

	19 <body>

	20 <div>This test checks that the grid's margins do not collapse with the margins o f its contents.</div>

	21 <div class="basic grid">

	22 <div class="item firstRowFirstColumn"></div>
	ojan 2014/05/21 18:43:12 Please use consistent indentation (i.e. use 4 spac Please use consistent indentation (i.e. use 4 space indent here). jfernandez 2014/05/22 14:40:46 Done. Show quoted text On 2014/05/21 18:43:12, ojan wrote: > Please use consistent indentation (i.e. use 4 space indent here). Done.
	23 </div>

	24 </body>

	25 </html>

	26

OLD	NEW

« no previous file with comments | « no previous file | LayoutTests/fast/css-grid-layout/grid-margins-not-collapse-expected.html » ('j') | no next file with comments »