Issue 273643008: New Layout Tests to verify grid container's margin don't collapse.

Issue 273643008: New Layout Tests to verify grid container's margin don't collapse. (Closed)

Created:
6 years, 7 months ago by jfernandez

Modified:
6 years, 7 months ago

Reviewers:
Julien - ping for review, eseidel, ojan

CC:
blink-reviews, svillar, jfernandez, Manuel Rego

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

More Reviews

Description

New Layout Tests to verify grid container's margin don't collapse. BUG=79180 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=174620

Patch Set 2 : Applied suggested changes. #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+43 lines, -0 lines)			Patch
	A	LayoutTests/fast/css-grid-layout/grid-margins-not-collapse.html	View	1	1 chunk	+20 lines, -0 lines	0 comments	Download
	A	LayoutTests/fast/css-grid-layout/grid-margins-not-collapse-expected.html	View	1	1 chunk	+23 lines, -0 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

ojan

https://codereview.chromium.org/273643008/diff/1/LayoutTests/fast/css-grid-layout/grid-margins-not-collapse.html File LayoutTests/fast/css-grid-layout/grid-margins-not-collapse.html (right): https://codereview.chromium.org/273643008/diff/1/LayoutTests/fast/css-grid-layout/grid-margins-not-collapse.html#newcode2 LayoutTests/fast/css-grid-layout/grid-margins-not-collapse.html:2: <html> We usually leave out the <html><head> and <body> ...

6 years, 7 months ago (2014-05-21 18:43:12 UTC) #3

jfernandez

Applied suggested changes. https://codereview.chromium.org/273643008/diff/1/LayoutTests/fast/css-grid-layout/grid-margins-not-collapse.html File LayoutTests/fast/css-grid-layout/grid-margins-not-collapse.html (right): https://codereview.chromium.org/273643008/diff/1/LayoutTests/fast/css-grid-layout/grid-margins-not-collapse.html#newcode2 LayoutTests/fast/css-grid-layout/grid-margins-not-collapse.html:2: <html> On 2014/05/21 18:43:12, ojan wrote: ...

6 years, 7 months ago (2014-05-22 14:40:46 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jfernandez@igalia.com/273643008/20001

6 years, 7 months ago (2014-05-22 22:24:42 UTC) #6

Message was sent while issue was closed.

Change committed as 174620

Expand Messages | Collapse Messages