Chromium Code Reviews Chromium Code Reviews
Issue
273643007:
Convert all SkRecordPattern matchers into SkRecord mutators. (Closed)
DescriptionConvert all SkRecordPattern matchers into SkRecord mutators.
- Allow any return type from SkRecord mutators and visitors;
- update existing calls to mutate and visit;
- convert match to operator() in SkRecordPattern;
- tidy up a few inelegant bits of old code in tests.
The net result is that the generated code is much clearer. All the mutate() calls
inline as you'd hope, and you can now actually follow along with the disassembly.
BUG=skia:2378
Committed: http://code.google.com/p/skia/source/detail?r=14631
Patch Set 1 #Patch Set 2 : unused #Patch Set 3 : defaults #Patch Set 4 : indent #Patch Set 5 : dumper too #
Messages
Total messages: 12 (0 generated)
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
