Css support-hack for improper webkit-padding-end behaviour.

Css support-hack for improper webkit-padding-end behaviour.

BUG=363836
NOTRY=true
TBR=ygorshenin@chromium.org, antrim@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270055

[merkulova, 2014-05-07 10:30:46]

Copying my bug-comment here:

***
Interesting enough:
-webkit-padding-end property doesn't catch right the ltr-rtl direction change.
It applies ltr logic on these rtl cases.

If you toggle any css property for .step-controls off and on at dev-tools,
-webkit-padding-end updates direction properly. From that moment it always sets
right direction on any language changes.

If you switch to Arabic first (proper rendering) and then to Hebrew or Persian,
you still meet the bug. So the direction's somehow improperly updated.

I have no idea if it's a complex webkit-bug or localization bug on our side. 
***

Any ideas on the original reason for such behaviour?

[merkulova, 2014-05-07 11:10:51]

+Denis for ideas

[Nikita (slow), 2014-05-08 07:34:14]

I wonder why bug report says that this issue only reproduces on some of rtl
locales?

>> Checking RTL language: this issue repros for Persian and Hebrew. Issue does
not repro for Arabic.

[Nikita (slow), 2014-05-08 07:37:24]

https://codereview.chromium.org/273643002/diff/1/chrome/browser/resources/chr...
File chrome/browser/resources/chromeos/login/oobe_screen.css (right):

https://codereview.chromium.org/273643002/diff/1/chrome/browser/resources/chr...
chrome/browser/resources/chromeos/login/oobe_screen.css:56: html[dir=rtl]
.step-controls {
This may be as well be a bug of
display: -webkit-box

This layout is deprecated and may contain bugs.

Instead of applying this hack I encourage you to change this div layout to flex
box (display: flex).

See https://codereview.chromium.org/262653003 for example.

[merkulova, 2014-05-08 14:17:46]

https://codereview.chromium.org/273643002/diff/1/chrome/browser/resources/chr...
File chrome/browser/resources/chromeos/login/oobe_screen.css (right):

https://codereview.chromium.org/273643002/diff/1/chrome/browser/resources/chr...
chrome/browser/resources/chromeos/login/oobe_screen.css:56: html[dir=rtl]
.step-controls {
On 2014/05/08 07:37:25, Nikita Kostylev wrote:
> This may be as well be a bug of
> display: -webkit-box
> 
> This layout is deprecated and may contain bugs.
> 
> Instead of applying this hack I encourage you to change this div layout to
flex
> box (display: flex).
> 
Switched to flex, but it doesn't solve the problem.
> See https://codereview.chromium.org/262653003 for example.

[Nikita (slow), 2014-05-12 15:15:31]

Let's try just attribute (dir=rtl) approach then.

[Nikita (slow), 2014-05-13 08:42:46]

lgtm 

You may use notry=true

[merkulova, 2014-05-13 08:49:56]

The CQ bit was checked by merkulova@chromium.org

[commit-bot: I haz the power, 2014-05-13 08:50:24]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/merkulova@chromium.org/273643002/20001

[commit-bot: I haz the power, 2014-05-13 08:51:40]

Change committed as 270055