Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(239)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 262653003: Fix user import pod size, fix "import user" link alignment. (Closed)

Created:
6 years, 7 months ago by Denis Kuznetsov (DE-MUC)
Modified:
6 years, 7 months ago
Reviewers:
Nikita (slow)
CC:
chromium-reviews, pam+watch_chromium.org, stevenjb+watch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org
Visibility:
Public.

Description

Fix user import pod size, fix "import user" link alignment. R=nkostylev@chromium.org BUG=360588 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=267271

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix indent #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -21 lines) Patch
M chrome/browser/resources/chromeos/login/screen_locally_managed_user_creation.css View 2 chunks +20 lines, -3 lines 0 comments Download
M chrome/browser/resources/chromeos/login/screen_locally_managed_user_creation.html View 1 1 chunk +6 lines, -6 lines 0 comments Download
M chrome/browser/resources/chromeos/login/screen_locally_managed_user_creation.js View 2 chunks +16 lines, -12 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
Denis Kuznetsov (DE-MUC)
6 years, 7 months ago (2014-04-30 15:45:39 UTC) #1
Nikita (slow)
lgtm https://codereview.chromium.org/262653003/diff/1/chrome/browser/resources/chromeos/login/screen_locally_managed_user_creation.html File chrome/browser/resources/chromeos/login/screen_locally_managed_user_creation.html (right): https://codereview.chromium.org/262653003/diff/1/chrome/browser/resources/chromeos/login/screen_locally_managed_user_creation.html#newcode136 chrome/browser/resources/chromeos/login/screen_locally_managed_user_creation.html:136: <div class="template-status-container status-container" hidden> nit: Indent should be ...
6 years, 7 months ago (2014-04-30 16:05:05 UTC) #2
Denis Kuznetsov (DE-MUC)
The CQ bit was checked by antrim@chromium.org
6 years, 7 months ago (2014-04-30 16:15:31 UTC) #3
Denis Kuznetsov (DE-MUC)
https://chromiumcodereview.appspot.com/262653003/diff/1/chrome/browser/resources/chromeos/login/screen_locally_managed_user_creation.html File chrome/browser/resources/chromeos/login/screen_locally_managed_user_creation.html (right): https://chromiumcodereview.appspot.com/262653003/diff/1/chrome/browser/resources/chromeos/login/screen_locally_managed_user_creation.html#newcode136 chrome/browser/resources/chromeos/login/screen_locally_managed_user_creation.html:136: <div class="template-status-container status-container" hidden> On 2014/04/30 16:05:05, Nikita Kostylev ...
6 years, 7 months ago (2014-04-30 16:15:49 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/antrim@chromium.org/262653003/20001
6 years, 7 months ago (2014-04-30 16:15:58 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-04-30 16:17:55 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel on tryserver.chromium
6 years, 7 months ago (2014-04-30 16:17:55 UTC) #7
Denis Kuznetsov (DE-MUC)
The CQ bit was checked by antrim@chromium.org
6 years, 7 months ago (2014-04-30 17:07:00 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/antrim@chromium.org/262653003/20001
6 years, 7 months ago (2014-04-30 17:07:59 UTC) #9
commit-bot: I haz the power
6 years, 7 months ago (2014-04-30 18:18:41 UTC) #10
Message was sent while issue was closed. 
Change committed as 267271

Powered by Google App Engine
This is Rietveld 408576698