Chromium Code Reviews
Description[Android] Restart input only once on focus change
Even when finishComposingText() returns false in
InputMethodController::willChangeFocus(), we do not need to reset input
because RenderFrameImpl::focusedNodeChanged() will reset input in the
later part of focus change process.
Also, currently updateKeyboardVisibility() and updateState() in ImeAdapter
may each restart input which is another source of redundant restart input.
By merging the code path and changing some order of execution, we can
reduce additional restart input.
Lastly, we defer restartInput until the next state update. By the time we
send FocusedNodeChanged, selection is not created for the newly focused
input because of the reason mentioned in http://crbug.com/650204#c17,
so we want to defer it in order to provide correct initial sel values for
View#onCreateInputConnection().
BUG=650204
Review-Url: https://codereview.chromium.org/2681833006
Cr-Commit-Position: refs/heads/master@{#451269}
(cherry picked from commit 62f5729e30dc50465f85419949564cb6e786dd49)
Review-Url: https://codereview.chromium.org/2736413002 .
Cr-Commit-Position: refs/branch-heads/2987@{#807}
Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943}
Committed: https://chromium.googlesource.com/chromium/src/+/9353655a861dd23ab239f5f400650bc04050ca2e
Patch Set 1 #Patch Set 2 : Rebase #Messages
Total messages: 2 (1 generated)
|