Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(277)

Issue 2736413002: [Android] Restart input only once on focus change (Closed)

Created:
3 years, 9 months ago by aelias_OOO_until_Jul13
Modified:
3 years, 9 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2987
Project:
chromium
Visibility:
Public.

Description

[Android] Restart input only once on focus change Even when finishComposingText() returns false in InputMethodController::willChangeFocus(), we do not need to reset input because RenderFrameImpl::focusedNodeChanged() will reset input in the later part of focus change process. Also, currently updateKeyboardVisibility() and updateState() in ImeAdapter may each restart input which is another source of redundant restart input. By merging the code path and changing some order of execution, we can reduce additional restart input. Lastly, we defer restartInput until the next state update. By the time we send FocusedNodeChanged, selection is not created for the newly focused input because of the reason mentioned in http://crbug.com/650204#c17, so we want to defer it in order to provide correct initial sel values for View#onCreateInputConnection(). BUG=650204 Review-Url: https://codereview.chromium.org/2681833006 Cr-Commit-Position: refs/heads/master@{#451269} (cherry picked from commit 62f5729e30dc50465f85419949564cb6e786dd49) Review-Url: https://codereview.chromium.org/2736413002 . Cr-Commit-Position: refs/branch-heads/2987@{#807} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} Committed: https://chromium.googlesource.com/chromium/src/+/9353655a861dd23ab239f5f400650bc04050ca2e

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+91 lines, -77 lines) Patch
M content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java View 1 chunk +3 lines, -4 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/input/ImeAdapter.java View 6 chunks +35 lines, -39 lines 0 comments Download
M content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java View 2 chunks +37 lines, -7 lines 0 comments Download
M content/renderer/input/render_widget_input_handler_delegate.h View 1 chunk +3 lines, -0 lines 0 comments Download
M content/renderer/render_frame_impl.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M content/renderer/render_view_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/render_view_impl.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M content/renderer/render_widget.h View 2 chunks +1 line, -1 line 0 comments Download
M content/renderer/render_widget.cc View 2 chunks +8 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/editing/InputMethodController.cpp View 1 chunk +1 line, -3 lines 0 comments Download
M third_party/WebKit/Source/web/ChromeClientImpl.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/web/ChromeClientImpl.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M third_party/WebKit/public/web/WebViewClient.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/public/web/WebWidgetClient.h View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
aelias_OOO_until_Jul13
3 years, 9 months ago (2017-03-09 20:00:21 UTC) #2
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
9353655a861dd23ab239f5f400650bc04050ca2e.

Powered by Google App Engine
This is Rietveld 408576698