Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Issue 2736393004: base: Remove LazyInstance with AtExit from process_linux.cc (Closed)

Created:
3 years, 9 months ago by danakj
Modified:
3 years, 9 months ago
Reviewers:
dcheng
CC:
chromium-reviews, vmpstr+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

base: Remove LazyInstance with AtExit from process_linux.cc Replace it with a function static, as it has no destructor to run. R=dcheng@chromium.org BUG=698982 Review-Url: https://codereview.chromium.org/2736393004 Cr-Commit-Position: refs/heads/master@{#456079} Committed: https://chromium.googlesource.com/chromium/src/+/6c77b2f4468702c9d4fc551d6e7bb3fbf25c2922

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -9 lines) Patch
M base/process/process_linux.cc View 4 chunks +10 lines, -9 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
danakj
3 years, 9 months ago (2017-03-09 23:38:36 UTC) #1
dcheng
LGTM. I suppose if we ever decide the extra indirection matters, we can change it ...
3 years, 9 months ago (2017-03-10 04:15:11 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2736393004/1
3 years, 9 months ago (2017-03-10 16:31:55 UTC) #8
commit-bot: I haz the power
3 years, 9 months ago (2017-03-10 16:41:12 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/6c77b2f4468702c9d4fc551d6e7b...

Powered by Google App Engine
This is Rietveld 408576698