Removed CRWWebDelagate callbacks for load cancellation.

Removed CRWWebDelagate callbacks for load cancellation.

When load is cancelled Tab already receives webStateDidStopLoading:.
In that callback it is safe to call |enableFullScreen| because the page
will not continue loading and fullscreen can be allowed.

webStateDidStopLoading: enables fullscreen and notifies tab model that
tab was changes. This allows removing deprecated
|webCancelStartLoadingRequest| and |webLoadCancelled:|.

BUG=674991
Review-Url: https://codereview.chromium.org/2736383006
Cr-Commit-Position: refs/heads/master@{#457162}
Committed: https://chromium.googlesource.com/chromium/src/+/4cc620ab46c8194efedfd1d78e7159d5968d692b

[Eugene But (OOO till 7-30), 2017-03-10 21:55:56]

The CQ bit was checked by eugenebut@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-10 21:56:15]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-10 22:11:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-10 22:11:12]

Dry run: This issue passed the CQ dry run.

[Eugene But (OOO till 7-30), 2017-03-10 23:43:00]

eugenebut@chromium.org changed reviewers:
+ kkhorimoto@chromium.org

[Eugene But (OOO till 7-30), 2017-03-10 23:43:00]

https://codereview.chromium.org/2736383006/diff/1/ios/chrome/browser/tabs/tab.mm
File ios/chrome/browser/tabs/tab.mm (left):

https://codereview.chromium.org/2736383006/diff/1/ios/chrome/browser/tabs/tab...
ios/chrome/browser/tabs/tab.mm:1669: - (void)webCancelStartLoadingRequest {
webStateDidStopLoading: is also called when provisional navigation is cancelled,
so this method can be removed.

[Eugene But (OOO till 7-30), 2017-03-14 18:01:17]

Kurt?

[kkhorimoto, 2017-03-15 18:36:56]

lgtm

[Eugene But (OOO till 7-30), 2017-03-15 18:39:08]

Thanks!

[Eugene But (OOO till 7-30), 2017-03-15 18:39:11]

The CQ bit was checked by eugenebut@chromium.org

[commit-bot: I haz the power, 2017-03-15 18:39:45]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-15 19:19:45]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1489603151863800, "parent_rev":
"8d999e64f8979a9513f19da5cd7adbe32c7be1d4", "commit_rev":
"4cc620ab46c8194efedfd1d78e7159d5968d692b"}

[commit-bot: I haz the power, 2017-03-15 19:21:09]

Description was changed from

==========
Removed CRWWebDelagate callbacks for load cancellation.

When load is cancelled Tab already receives webStateDidStopLoading:.
In that callback it is safe to call |enableFullScreen| because the page
will not continue loading and fullscreen can be allowed.

webStateDidStopLoading: enables fullscreen and notifies tab model that
tab was changes. This allows removing deprecated
|webCancelStartLoadingRequest| and |webLoadCancelled:|.

BUG=674991
==========

to

==========
Removed CRWWebDelagate callbacks for load cancellation.

When load is cancelled Tab already receives webStateDidStopLoading:.
In that callback it is safe to call |enableFullScreen| because the page
will not continue loading and fullscreen can be allowed.

webStateDidStopLoading: enables fullscreen and notifies tab model that
tab was changes. This allows removing deprecated
|webCancelStartLoadingRequest| and |webLoadCancelled:|.

BUG=674991

Review-Url: https://codereview.chromium.org/2736383006
Cr-Commit-Position: refs/heads/master@{#457162}
Committed:
https://chromium.googlesource.com/chromium/src/+/4cc620ab46c8194efedfd1d78e71...
==========

[commit-bot: I haz the power, 2017-03-15 19:21:10]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/4cc620ab46c8194efedfd1d78e71...