[regexp] Properly flatten string during initialization

[regexp] Properly flatten string during initialization

This fixes an incorrect usage of String::Flatten in EscapeRegExpSource.

It also adds %ConstructConsString (to easily and reliably construct cons
strings in tests) and Factory::NewConsString (to enable guaranteed cons
string construction without preemptive flattening attempts).

BUG=chromium:698790
Review-Url: https://codereview.chromium.org/2736383003
Cr-Commit-Position: refs/heads/master@{#43686}
Committed: https://chromium.googlesource.com/v8/v8/+/5002a4a96144cd1c1d2031314e39c7dee68fc450

[jgruber, 2017-03-09 08:47:08]

The CQ bit was checked by jgruber@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-09 08:47:09]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jgruber, 2017-03-09 08:49:21]

jgruber@chromium.org changed reviewers:
+ yangguo@chromium.org

[commit-bot: I haz the power, 2017-03-09 09:18:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-09 09:18:45]

Dry run: This issue passed the CQ dry run.

[Yang, 2017-03-09 09:36:57]

On 2017/03/09 08:49:21, jgruber wrote:

lgtm.

[Yang, 2017-03-09 09:37:07]

https://codereview.chromium.org/2736383003/diff/1/src/factory.cc
File src/factory.cc (right):

https://codereview.chromium.org/2736383003/diff/1/src/factory.cc#newcode722
src/factory.cc:722: DCHECK(0 <= length && length <= String::kMaxLength);
The 0 <= length check is a bit redundant, considering the next line checks
against ConsString::kMinLength

[jgruber, 2017-03-09 09:55:16]

https://codereview.chromium.org/2736383003/diff/1/src/factory.cc
File src/factory.cc (right):

https://codereview.chromium.org/2736383003/diff/1/src/factory.cc#newcode722
src/factory.cc:722: DCHECK(0 <= length && length <= String::kMaxLength);
On 2017/03/09 09:37:07, Yang wrote:
> The 0 <= length check is a bit redundant, considering the next line checks
> against ConsString::kMinLength

Yup noticed that myself. Will fix and land after.

[jgruber, 2017-03-09 09:57:00]

The CQ bit was checked by jgruber@chromium.org

[jgruber, 2017-03-09 09:57:00]

The patchset sent to the CQ was uploaded after l-g-t-m from yangguo@chromium.org
Link to the patchset: https://codereview.chromium.org/2736383003/#ps20001
(title: "Better DCHECKs")

[commit-bot: I haz the power, 2017-03-09 09:57:09]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-09 12:25:23]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1489053420167300,
"parent_rev": "e9a25e287d5127114facc61385c1dc00305a25ca", "commit_rev":
"5002a4a96144cd1c1d2031314e39c7dee68fc450"}

[commit-bot: I haz the power, 2017-03-09 12:25:29]

Description was changed from

==========
[regexp] Properly flatten string during initialization

This fixes an incorrect usage of String::Flatten in EscapeRegExpSource.

It also adds %ConstructConsString (to easily and reliably construct cons
strings in tests) and Factory::NewConsString (to enable guaranteed cons
string construction without preemptive flattening attempts).

BUG=chromium:698790
==========

to

==========
[regexp] Properly flatten string during initialization

This fixes an incorrect usage of String::Flatten in EscapeRegExpSource.

It also adds %ConstructConsString (to easily and reliably construct cons
strings in tests) and Factory::NewConsString (to enable guaranteed cons
string construction without preemptive flattening attempts).

BUG=chromium:698790

Review-Url: https://codereview.chromium.org/2736383003
Cr-Commit-Position: refs/heads/master@{#43686}
Committed:
https://chromium.googlesource.com/v8/v8/+/5002a4a96144cd1c1d2031314e39c7dee68...
==========

[commit-bot: I haz the power, 2017-03-09 12:25:30]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/5002a4a96144cd1c1d2031314e39c7dee68...