Gracefully degrade summarization when an annotation is not a valid const expression (issue 28992)

pkg/analyzer/test/src/summary/summary_common.dart

Index: pkg/analyzer/test/src/summary/summary_common.dart
diff --git a/pkg/analyzer/test/src/summary/summary_common.dart b/pkg/analyzer/test/src/summary/summary_common.dart
index 001263ca407c33d4c7871bb88af955cfc6093516..48502a5673e5d98ede9326b6c192220ce518c575 100644
--- a/pkg/analyzer/test/src/summary/summary_common.dart
+++ b/pkg/analyzer/test/src/summary/summary_common.dart
@@ -18,6 +18,7 @@ import 'package:analyzer/src/summary/public_namespace_computer.dart'
     as public_namespace;
 import 'package:path/path.dart' show posix;
 import 'package:test/test.dart';
+import 'package:test_reflective_loader/test_reflective_loader.dart';
 
 import '../context/mock_sdk.dart';
 
@@ -3489,6 +3490,11 @@ const v = p.C.foo;
         operators: [UnlinkedExprOperation.pushTrue]);
   }
 
+  test_constExpression_invalidAssignable() {
+    // Verify that the following does not produce an exception.
+    serializeLibraryText('@a(-b=""c');

[scheglov, 2017/03/09 20:24:54]

May be worth to move to other test_metadata_invalid_* tests and check that
annotation is empty.

[Brian Wilkerson, 2017/03/09 22:32:51]

I'm happy to rename the test, but I have no idea how to test that the annotation
is empty. Perhaps we can discuss off-line.

[Brian Wilkerson, 2017/03/09 22:51:13]

Done

+  }
+
   test_constructor() {
     String text = 'class C { C(); }';
     UnlinkedExecutable executable =