Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(328)

Unified Diff: pkg/analyzer/lib/src/summary/summarize_ast.dart

Issue 2736373004: Gracefully degrade summarization when an annotation is not a valid const expression (issue 28992) (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analyzer/lib/src/summary/summarize_ast.dart
diff --git a/pkg/analyzer/lib/src/summary/summarize_ast.dart b/pkg/analyzer/lib/src/summary/summarize_ast.dart
index 240fa8000cae17a4614eb07cb90d362c4ba6ccb7..7273e3f474e31696f5fb08a33670d44ee28c56b2 100644
--- a/pkg/analyzer/lib/src/summary/summarize_ast.dart
+++ b/pkg/analyzer/lib/src/summary/summarize_ast.dart
@@ -414,7 +414,11 @@ class _SummarizeAstVisitor extends RecursiveAstVisitor {
Map<int, int> localClosureIndexMap = null;
_ConstExprSerializer serializer =
new _ConstExprSerializer(this, localClosureIndexMap, null);
- serializer.serializeAnnotation(a);
+ try {
+ serializer.serializeAnnotation(a);
+ } on StateError {
+ return new UnlinkedExprBuilder()..isValidConst = false;
+ }
return serializer.toBuilder();
}).toList();
}
« no previous file with comments | « no previous file | pkg/analyzer/test/src/summary/summary_common.dart » ('j') | pkg/analyzer/test/src/summary/summary_common.dart » ('J')

Powered by Google App Engine
This is Rietveld 408576698