Gracefully degrade summarization when an annotation is not a valid const expression (issue 28992)

Gracefully degrade summarization when an annotation is not a valid const expression (issue 28992)

R=scheglov@google.com

Committed: https://github.com/dart-lang/sdk/commit/0fc6d8655252c3569afc65ddc2aeee8e062701cf

[Brian Wilkerson, 2017-03-09 20:19:19]

brianwilkerson@google.com changed reviewers:
+ scheglov@google.com

[scheglov, 2017-03-09 20:24:54]

lgtm

https://codereview.chromium.org/2736373004/diff/1/pkg/analyzer/test/src/summa...
File pkg/analyzer/test/src/summary/summary_common.dart (right):

https://codereview.chromium.org/2736373004/diff/1/pkg/analyzer/test/src/summa...
pkg/analyzer/test/src/summary/summary_common.dart:3495:
serializeLibraryText('@a(-b=""c');
May be worth to move to other test_metadata_invalid_* tests and check that
annotation is empty.

[Brian Wilkerson, 2017-03-09 22:32:51]

https://codereview.chromium.org/2736373004/diff/1/pkg/analyzer/test/src/summa...
File pkg/analyzer/test/src/summary/summary_common.dart (right):

https://codereview.chromium.org/2736373004/diff/1/pkg/analyzer/test/src/summa...
pkg/analyzer/test/src/summary/summary_common.dart:3495:
serializeLibraryText('@a(-b=""c');
I'm happy to rename the test, but I have no idea how to test that the annotation
is empty. Perhaps we can discuss off-line.

[Brian Wilkerson, 2017-03-09 22:51:13]

https://codereview.chromium.org/2736373004/diff/1/pkg/analyzer/test/src/summa...
File pkg/analyzer/test/src/summary/summary_common.dart (right):

https://codereview.chromium.org/2736373004/diff/1/pkg/analyzer/test/src/summa...
pkg/analyzer/test/src/summary/summary_common.dart:3495:
serializeLibraryText('@a(-b=""c');
Done

[Brian Wilkerson, 2017-03-09 22:51:13]

https://codereview.chromium.org/2736373004/diff/1/pkg/analyzer/test/src/summa...
File pkg/analyzer/test/src/summary/summary_common.dart (right):

https://codereview.chromium.org/2736373004/diff/1/pkg/analyzer/test/src/summa...
pkg/analyzer/test/src/summary/summary_common.dart:3495:
serializeLibraryText('@a(-b=""c');
Done

[Brian Wilkerson, 2017-03-10 17:39:43]

Description was changed from

==========
Gracefully degrade summarization when an annotation is not a valid const
expression (issue 28992)
==========

to

==========
Gracefully degrade summarization when an annotation is not a valid const
expression (issue 28992)

R=scheglov@google.com

Committed:
https://github.com/dart-lang/sdk/commit/0fc6d8655252c3569afc65ddc2aeee8e062701cf
==========

[Brian Wilkerson, 2017-03-10 17:39:44]

Committed patchset #1 (id:1) manually as
0fc6d8655252c3569afc65ddc2aeee8e062701cf (presubmit successful).