Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(384)

Issue 2736363002: base: Make TimeDurationFormat* report failures. (Closed)

Created:
3 years, 9 months ago by Daniel Erat
Modified:
3 years, 9 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/3029
Project:
chromium
Visibility:
Public.

Description

base: Make TimeDurationFormat* report failures. Update base::TimeDurationFormat() and base::TimeDurationFormatWithSeconds() to return boolean "success" values and use out-params to return formatted strings. ICU errors were formerly swallowed, which makes it impossible for the UI to handle them gracefully or for developers to investigate their causes. BUG=698802, 677043 Review-Url: https://codereview.chromium.org/2734883003 Cr-Commit-Position: refs/heads/master@{#455144} (cherry picked from commit efcd30ca164e0e1bbcfe402840d8c23aa9d40fd9) Review-Url: https://codereview.chromium.org/2736363002 . Cr-Commit-Position: refs/branch-heads/3029@{#73} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} Committed: https://chromium.googlesource.com/chromium/src/+/eaf9c6686c55d0b2d3cbe2c69818db7f017187e7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+116 lines, -48 lines) Patch
M ash/common/system/chromeos/power/battery_notification.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M ash/common/system/chromeos/power/power_status_view.cc View 1 chunk +5 lines, -1 line 0 comments Download
M base/i18n/time_formatting.h View 3 chunks +16 lines, -8 lines 0 comments Download
M base/i18n/time_formatting.cc View 3 chunks +33 lines, -6 lines 0 comments Download
M base/i18n/time_formatting_unittest.cc View 5 chunks +53 lines, -29 lines 0 comments Download
M chrome/browser/ui/task_manager/task_manager_table_model.cc View 1 chunk +5 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
Daniel Erat
3 years, 9 months ago (2017-03-08 23:17:54 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
eaf9c6686c55d0b2d3cbe2c69818db7f017187e7.

Powered by Google App Engine
This is Rietveld 408576698