Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(255)

Issue 2736313002: Replace TestLaucher non-leaky LazyInstances with a static pointers. (Closed)

Created:
3 years, 9 months ago by danakj
Modified:
3 years, 9 months ago
Reviewers:
dcheng
CC:
chromium-reviews, vmpstr+watch_chromium.org, scottmg
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Replace TestLaucher non-leaky LazyInstances with a static pointers. This avoids running destructors at shutdown. R=dcheng@chromium.org BUG=698982 Review-Url: https://codereview.chromium.org/2736313002 Cr-Commit-Position: refs/heads/master@{#456092} Committed: https://chromium.googlesource.com/chromium/src/+/5759cafbf041c1fdc2b26416b4644e52f7df6dfc

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -40 lines) Patch
M base/test/launcher/test_launcher.cc View 10 chunks +35 lines, -40 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
danakj
3 years, 9 months ago (2017-03-08 20:44:09 UTC) #2
danakj
bump
3 years, 9 months ago (2017-03-10 16:28:39 UTC) #6
dcheng
lgtm
3 years, 9 months ago (2017-03-10 16:32:43 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2736313002/1
3 years, 9 months ago (2017-03-10 16:34:00 UTC) #9
commit-bot: I haz the power
3 years, 9 months ago (2017-03-10 17:35:43 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/5759cafbf041c1fdc2b26416b464...

Powered by Google App Engine
This is Rietveld 408576698