Allow ParsedContentType to reject multiple definitions of the same parameter

Allow ParsedContentType to reject multiple definitions of the same parameter

The code in ParsedContentType is based on RFC2045, which does not mention what
should happen if the same parameter name is mentioned multiple times. However,
RFC6838 (Media Type Specifications and Registration Procedures), which defines
the MIME types for media and is based on RFC2045/2046, has the following
statement:
  It is an error for a specific parameter to be specified more than once.

Add an option to have ParsedContentType fail if the same parameter is
specified multiple times. navigator.requestMediaKeySystemAccess() is updated
to reject MIME types that mention the same parameter name more than once.

BUG=698436
TEST=new tests pass

Review-Url: https://codereview.chromium.org/2736283002
Cr-Commit-Position: refs/heads/master@{#456167}
Committed: https://chromium.googlesource.com/chromium/src/+/5f918117c5bfed1b2f5cd8d2bab14a895814db8f

[jrummell, 2017-03-08 19:03:08]

jrummell@chromium.org changed reviewers:
+ xhwang@chromium.org, yhirano@chromium.org

[jrummell, 2017-03-08 19:03:08]

PTAL.

[xhwang, 2017-03-08 21:43:22]

lgtm

[xhwang, 2017-03-08 21:48:27]

BTW, since you have went through all related RFCs, could you provide some more
context in the comment (e.g. what RFCs you looked at, which ones specifically
disallow this, etc)? Otherwise, the knowledge will be lost over time.

[yhirano, 2017-03-09 08:26:38]

https://codereview.chromium.org/2736283002/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/network/ParsedContentType.cpp (right):

https://codereview.chromium.org/2736283002/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/network/ParsedContentType.cpp:270:
DCHECK(keyString.containsOnlyASCII());
Please have this DCHECK before calling lower() (Also this should be
key.toString().constainsOnlyASCII()).

[jrummell, 2017-03-10 02:21:49]

Description was changed from

==========
Allow parsedContentType to reject multiple definitions of the same parameter

Some newer RFC's (e.g. RFC6838, Media Type Specifications and Registration
Procedures) specify that parameters cannot be specified multiple times in the
MIME type. Add an option to have ParsedContentType fail if the same parameter
is specified multiple times.

BUG=698436
TEST=new tests pass
==========

to

==========
Allow ParsedContentType to reject multiple definitions of the same parameter

The code in ParsedContentType is based on RFC2045, which does not mention what
should happen if the same parameter name is mentioned multiple times. However,
RFC6838 (Media Type Specifications and Registration Procedures), which defines
the MIME types for media and is based on RFC2045/2046, has the following
statement:
  It is an error for a specific parameter to be specified more than once.

Add an option to have ParsedContentType fail if the same parameter is
specified multiple times. navigator.requestMediaKeySystemAccess() is updated
to reject MIME types that mention the same parameter name more than once.

BUG=698436
TEST=new tests pass
==========

[jrummell, 2017-03-10 02:27:02]

Updated.

https://codereview.chromium.org/2736283002/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/network/ParsedContentType.cpp (right):

https://codereview.chromium.org/2736283002/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/network/ParsedContentType.cpp:270:
DCHECK(keyString.containsOnlyASCII());
On 2017/03/09 08:26:38, yhirano (slow) wrote:
> Please have this DCHECK before calling lower() (Also this should be
> key.toString().constainsOnlyASCII()).

Done.

[yhirano, 2017-03-10 09:04:57]

lgtm

[jrummell, 2017-03-10 18:55:35]

The CQ bit was checked by jrummell@chromium.org

[jrummell, 2017-03-10 18:55:35]

The patchset sent to the CQ was uploaded after l-g-t-m from xhwang@chromium.org
Link to the patchset: https://codereview.chromium.org/2736283002/#ps20001
(title: "check first")

[commit-bot: I haz the power, 2017-03-10 18:56:11]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-10 19:05:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-10 19:05:59]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[haraken, 2017-03-10 19:09:08]

owner LGTM

[jrummell, 2017-03-10 20:52:55]

The CQ bit was checked by jrummell@chromium.org

[commit-bot: I haz the power, 2017-03-10 20:53:15]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-10 21:31:13]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1489179175013310,
"parent_rev": "2a2a964c75a71e56aa52790d2ce0bcd5a9af434a", "commit_rev":
"5f918117c5bfed1b2f5cd8d2bab14a895814db8f"}

[commit-bot: I haz the power, 2017-03-10 21:33:15]

Description was changed from

==========
Allow ParsedContentType to reject multiple definitions of the same parameter

The code in ParsedContentType is based on RFC2045, which does not mention what
should happen if the same parameter name is mentioned multiple times. However,
RFC6838 (Media Type Specifications and Registration Procedures), which defines
the MIME types for media and is based on RFC2045/2046, has the following
statement:
  It is an error for a specific parameter to be specified more than once.

Add an option to have ParsedContentType fail if the same parameter is
specified multiple times. navigator.requestMediaKeySystemAccess() is updated
to reject MIME types that mention the same parameter name more than once.

BUG=698436
TEST=new tests pass
==========

to

==========
Allow ParsedContentType to reject multiple definitions of the same parameter

The code in ParsedContentType is based on RFC2045, which does not mention what
should happen if the same parameter name is mentioned multiple times. However,
RFC6838 (Media Type Specifications and Registration Procedures), which defines
the MIME types for media and is based on RFC2045/2046, has the following
statement:
  It is an error for a specific parameter to be specified more than once.

Add an option to have ParsedContentType fail if the same parameter is
specified multiple times. navigator.requestMediaKeySystemAccess() is updated
to reject MIME types that mention the same parameter name more than once.

BUG=698436
TEST=new tests pass

Review-Url: https://codereview.chromium.org/2736283002
Cr-Commit-Position: refs/heads/master@{#456167}
Committed:
https://chromium.googlesource.com/chromium/src/+/5f918117c5bfed1b2f5cd8d2bab1...
==========

[commit-bot: I haz the power, 2017-03-10 21:33:17]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/5f918117c5bfed1b2f5cd8d2bab1...