Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Issue 2736273002: Mojo JS bindings: duplicate the bindings files into src/mojo/public/js/new_bindings. (Closed)

Created:
3 years, 9 months ago by yzshen1
Modified:
3 years, 9 months ago
CC:
Aaron Boodman, abarth-chromium, chromium-reviews, darin (slow to review), qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Mojo JS bindings: duplicate the bindings files into src/mojo/public/js/new_bindings. New module-loading approach will be developed on this copy. The original code will be removed after all user code is switched to the new approach. BUG=699569 Review-Url: https://codereview.chromium.org/2736273002 Cr-Commit-Position: refs/heads/master@{#455492} Committed: https://chromium.googlesource.com/chromium/src/+/e3c870b6d13a2b5a55deba853b04ad328fc4bc6b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2509 lines, -0 lines) Patch
A mojo/public/js/new_bindings/bindings.js View 1 chunk +285 lines, -0 lines 0 comments Download
A mojo/public/js/new_bindings/buffer.js View 1 chunk +156 lines, -0 lines 0 comments Download
A mojo/public/js/new_bindings/codec.js View 1 chunk +922 lines, -0 lines 0 comments Download
A mojo/public/js/new_bindings/connector.js View 1 chunk +115 lines, -0 lines 0 comments Download
A mojo/public/js/new_bindings/interface_types.js View 1 chunk +52 lines, -0 lines 0 comments Download
A mojo/public/js/new_bindings/lib/control_message_handler.js View 1 chunk +111 lines, -0 lines 0 comments Download
A mojo/public/js/new_bindings/lib/control_message_proxy.js View 1 chunk +102 lines, -0 lines 0 comments Download
A mojo/public/js/new_bindings/router.js View 1 chunk +203 lines, -0 lines 0 comments Download
A mojo/public/js/new_bindings/unicode.js View 1 chunk +51 lines, -0 lines 0 comments Download
A mojo/public/js/new_bindings/validator.js View 1 chunk +512 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
yzshen1
Hi, Ken. Would you please take a look? This is a simply copy. There is ...
3 years, 9 months ago (2017-03-08 15:49:58 UTC) #2
Ken Rockot(use gerrit already)
lgtm
3 years, 9 months ago (2017-03-08 17:43:54 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2736273002/1
3 years, 9 months ago (2017-03-08 17:48:15 UTC) #5
commit-bot: I haz the power
3 years, 9 months ago (2017-03-08 18:07:57 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/e3c870b6d13a2b5a55deba853b04...

Powered by Google App Engine
This is Rietveld 408576698