Add ios_web_view_shell_egtests target and accessibility labels to shell.

Add ios_web_view_shell_egtests target and accessibility labels to shell.

BUG=698657
Review-Url: https://codereview.chromium.org/2736243003
Cr-Commit-Position: refs/heads/master@{#455618}
Committed: https://chromium.googlesource.com/chromium/src/+/10253f303a50e68dd30f5b1f372d30646366cc2e

[michaeldo, 2017-03-08 21:13:14]

michaeldo@chromium.org changed reviewers:
+ eugenebut@chromium.org

[Eugene But (OOO till 7-30), 2017-03-08 21:42:44]

https://codereview.chromium.org/2736243003/diff/1/ios/web_view/shell/test/ear...
File ios/web_view/shell/test/earl_grey/shell_matchers.h (right):

https://codereview.chromium.org/2736243003/diff/1/ios/web_view/shell/test/ear...
ios/web_view/shell/test/earl_grey/shell_matchers.h:5: #ifndef
IOS_WEB_VIEW_SHELL_TEST_EARL_GREY_WEB_VIEW_SHELL_MATCHERS_H_
I think we should use different names for web shell and web view shell matchers.

https://codereview.chromium.org/2736243003/diff/1/ios/web_view/shell/test/ear...
File ios/web_view/shell/test/earl_grey/shell_matchers.mm (right):

https://codereview.chromium.org/2736243003/diff/1/ios/web_view/shell/test/ear...
ios/web_view/shell/test/earl_grey/shell_matchers.mm:7: #import
"base/mac/foundation_util.h"
Do we need this? If so, then it should be include, not import

https://codereview.chromium.org/2736243003/diff/1/ios/web_view/shell/test/ear...
ios/web_view/shell/test/earl_grey/shell_matchers.mm:33:
testing::kWaitForUIElementTimeout,
Do you want to use local variables to improve formatting?

https://codereview.chromium.org/2736243003/diff/1/ios/web_view/shell/test/she...
File ios/web_view/shell/test/shell_egtest.mm (right):

https://codereview.chromium.org/2736243003/diff/1/ios/web_view/shell/test/she...
ios/web_view/shell/test/shell_egtest.mm:7: // Empty test case file for the web
view shell.
We should try to align this with ShellBaseTestCase and have either 

WebShellBaseTestCase / WebViewShellBaseTestCase or
WebShellTestCase / WebViewShellTestCase

I guess baxley@ can tell us if there was a reason for suing Base work in the
class name

[michaeldo, 2017-03-08 21:58:31]

https://codereview.chromium.org/2736243003/diff/1/ios/web_view/shell/test/ear...
File ios/web_view/shell/test/earl_grey/shell_matchers.h (right):

https://codereview.chromium.org/2736243003/diff/1/ios/web_view/shell/test/ear...
ios/web_view/shell/test/earl_grey/shell_matchers.h:5: #ifndef
IOS_WEB_VIEW_SHELL_TEST_EARL_GREY_WEB_VIEW_SHELL_MATCHERS_H_
On 2017/03/08 21:42:44, Eugene But wrote:
> I think we should use different names for web shell and web view shell
matchers.

Do you mean filename should be more like web_view_shell_matchers? (Just wanted
to clarify as for the matchers, they are in a different namespace and the header
guard is different at the start.)

https://codereview.chromium.org/2736243003/diff/1/ios/web_view/shell/test/ear...
File ios/web_view/shell/test/earl_grey/shell_matchers.mm (right):

https://codereview.chromium.org/2736243003/diff/1/ios/web_view/shell/test/ear...
ios/web_view/shell/test/earl_grey/shell_matchers.mm:7: #import
"base/mac/foundation_util.h"
On 2017/03/08 21:42:44, Eugene But wrote:
> Do we need this? If so, then it should be include, not import

Done.

https://codereview.chromium.org/2736243003/diff/1/ios/web_view/shell/test/ear...
ios/web_view/shell/test/earl_grey/shell_matchers.mm:33:
testing::kWaitForUIElementTimeout,
On 2017/03/08 21:42:44, Eugene But wrote:
> Do you want to use local variables to improve formatting?

Done.

https://codereview.chromium.org/2736243003/diff/1/ios/web_view/shell/test/she...
File ios/web_view/shell/test/shell_egtest.mm (right):

https://codereview.chromium.org/2736243003/diff/1/ios/web_view/shell/test/she...
ios/web_view/shell/test/shell_egtest.mm:7: // Empty test case file for the web
view shell.
On 2017/03/08 21:42:44, Eugene But wrote:
> We should try to align this with ShellBaseTestCase and have either 
> 
> WebShellBaseTestCase / WebViewShellBaseTestCase or
> WebShellTestCase / WebViewShellTestCase
> 
> I guess baxley@ can tell us if there was a reason for suing Base work in the
> class name

I agree, I had a base class already but wanted to split the actual tests out of
the CL and so removed the base class from here.

[Eugene But (OOO till 7-30), 2017-03-08 22:12:03]

lgtm

https://codereview.chromium.org/2736243003/diff/1/ios/web_view/shell/test/ear...
File ios/web_view/shell/test/earl_grey/shell_matchers.h (right):

https://codereview.chromium.org/2736243003/diff/1/ios/web_view/shell/test/ear...
ios/web_view/shell/test/earl_grey/shell_matchers.h:5: #ifndef
IOS_WEB_VIEW_SHELL_TEST_EARL_GREY_WEB_VIEW_SHELL_MATCHERS_H_
On 2017/03/08 21:58:31, michaeldo wrote:
> On 2017/03/08 21:42:44, Eugene But wrote:
> > I think we should use different names for web shell and web view shell
> matchers.
> 
> Do you mean filename should be more like web_view_shell_matchers? (Just wanted
> to clarify as for the matchers, they are in a different namespace and the
header
> guard is different at the start.)
Sorry, I meant filename :)

[michaeldo, 2017-03-08 23:38:49]

https://codereview.chromium.org/2736243003/diff/1/ios/web_view/shell/test/ear...
File ios/web_view/shell/test/earl_grey/shell_matchers.h (right):

https://codereview.chromium.org/2736243003/diff/1/ios/web_view/shell/test/ear...
ios/web_view/shell/test/earl_grey/shell_matchers.h:5: #ifndef
IOS_WEB_VIEW_SHELL_TEST_EARL_GREY_WEB_VIEW_SHELL_MATCHERS_H_
On 2017/03/08 22:12:03, Eugene But wrote:
> On 2017/03/08 21:58:31, michaeldo wrote:
> > On 2017/03/08 21:42:44, Eugene But wrote:
> > > I think we should use different names for web shell and web view shell
> > matchers.
> > 
> > Do you mean filename should be more like web_view_shell_matchers? (Just
wanted
> > to clarify as for the matchers, they are in a different namespace and the
> header
> > guard is different at the start.)
> Sorry, I meant filename :)

No problem. Done.

[michaeldo, 2017-03-08 23:39:44]

The CQ bit was checked by michaeldo@chromium.org

[michaeldo, 2017-03-08 23:39:45]

The patchset sent to the CQ was uploaded after l-g-t-m from
eugenebut@chromium.org
Link to the patchset: https://codereview.chromium.org/2736243003/#ps40001
(title: "rename matchers file.")

[commit-bot: I haz the power, 2017-03-08 23:40:29]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-09 01:11:20]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1489016384779220,
"parent_rev": "7fdf43c8251e77df8fba1933f71b9a40b924359e", "commit_rev":
"10253f303a50e68dd30f5b1f372d30646366cc2e"}

[commit-bot: I haz the power, 2017-03-09 01:12:51]

Description was changed from

==========
Add ios_web_view_shell_egtests target and accessibility labels to shell.

BUG=698657
==========

to

==========
Add ios_web_view_shell_egtests target and accessibility labels to shell.

BUG=698657

Review-Url: https://codereview.chromium.org/2736243003
Cr-Commit-Position: refs/heads/master@{#455618}
Committed:
https://chromium.googlesource.com/chromium/src/+/10253f303a50e68dd30f5b1f372d...
==========

[commit-bot: I haz the power, 2017-03-09 01:12:52]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/10253f303a50e68dd30f5b1f372d...